From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Emil Tantilov <emil.s.tantilov@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 6/6] ixgbe: change the eeprom version reported by ethtool
Date: Mon, 17 Oct 2011 08:57:15 -0700 [thread overview]
Message-ID: <1318867035.5407.5.camel@Joe-Laptop> (raw)
In-Reply-To: <1318854062-3628-7-git-send-email-jeffrey.t.kirsher@intel.com>
On Mon, 2011-10-17 at 05:21 -0700, Jeff Kirsher wrote:
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> Use 32bit value starting at offset 0x2d for displaying the firmware
> version in ethtool. This should work for all current ixgbe HW
[]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
[]
> - snprintf(firmware_version, sizeof(firmware_version), "%d.%d-%d",
> - (adapter->eeprom_version & 0xF000) >> 12,
> - (adapter->eeprom_version & 0x0FF0) >> 4,
> - adapter->eeprom_version & 0x000F);
> + nvm_track_id = (adapter->eeprom_verh << 16) |
> + adapter->eeprom_verl;
> + snprintf(firmware_version, sizeof(firmware_version), "0x%08x",
> + nvm_track_id);
Is ethtool output like proc output considered an abi
that should not be changed?
next prev parent reply other threads:[~2011-10-17 15:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 12:20 [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-10-17 12:20 ` [net-next 1/6] igbvf: Fix trunk vlan Jeff Kirsher
2011-10-17 12:20 ` [net-next 2/6 v2] igb: Check if subordinate VFs are assigned to virtual machines Jeff Kirsher
2011-10-17 15:53 ` Joe Perches
2011-10-17 12:20 ` [net-next 3/6] ixgbe: fix endianess when writing driver version to firmware Jeff Kirsher
2011-10-17 12:21 ` [net-next 4/6] ixgbe: allow eeprom writes via ethtool Jeff Kirsher
2011-10-17 12:21 ` [net-next 5/6] ixgbe: add hardware timestamping support Jeff Kirsher
2011-10-17 16:44 ` Richard Cochran
2011-10-19 17:04 ` Jacob Keller
2011-10-20 14:56 ` Richard Cochran
2011-10-20 19:57 ` Keller, Jacob E
2011-10-17 12:21 ` [net-next 6/6] ixgbe: change the eeprom version reported by ethtool Jeff Kirsher
2011-10-17 15:57 ` Joe Perches [this message]
2011-10-17 17:16 ` Ben Hutchings
2011-10-17 18:02 ` Tantilov, Emil S
2011-10-17 22:49 ` [net-next 0/6 v2][pull request] Intel Wired LAN Driver Updates David Miller
2011-10-17 22:53 ` Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2011-10-17 11:32 [net-next 0/6][pull " Jeff Kirsher
2011-10-17 11:32 ` [net-next 6/6] ixgbe: change the eeprom version reported by ethtool Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318867035.5407.5.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.