From: john stultz <johnstul@us.ibm.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw
Date: Mon, 17 Oct 2011 12:09:41 -0700 [thread overview]
Message-ID: <1318878581.3125.81.camel@work-vm> (raw)
In-Reply-To: <1318877923-17792-1-git-send-email-dpmcgee@gmail.com>
On Mon, 2011-10-17 at 13:58 -0500, Dan McGee wrote:
> The whole point of this function is to return a value not touched by
> NTP; unfortunately the comment got copied wholesale without adjustment
> from the timekeeping_get_ns function above.
>
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
> kernel/time/timekeeping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index 2b021b0e..a5846a8 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -131,7 +131,7 @@ static inline s64 timekeeping_get_ns_raw(void)
> /* calculate the delta since the last update_wall_time: */
> cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
>
> - /* return delta convert to nanoseconds using ntp adjusted mult. */
> + /* return delta convert to nanoseconds. */
> return clocksource_cyc2ns(cycle_delta, clock->mult, clock->shift);
> }
Thanks for catching this! I'll apply it to my queue!
-john
prev parent reply other threads:[~2011-10-17 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 18:58 [PATCH] timekeeping: fix bogus comment in timekeeping_get_ns_raw Dan McGee
2011-10-17 19:09 ` john stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318878581.3125.81.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=dpmcgee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.