All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: yocto@yoctoproject.org
Subject: Re: why is "package-management" defined as a PACKAGE_GROUP?
Date: Sun, 17 Nov 2013 12:12:48 +0000	[thread overview]
Message-ID: <13190111.cIECxPcJYb@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1311170626370.18680@oneiric>

On Sunday 17 November 2013 06:30:01 Robert P. J. Day wrote:
> On Sun, 17 Nov 2013, Paul Eggleton wrote:
> > On Sunday 17 November 2013 04:19:19 Robert P. J. Day wrote:
> > >   think i may have asked this once upon a time, but why, in
> > > 
> > > core-image.bbclass, is there the line:
> > >   PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}"
> > > 
> > > as i read it, package-management doesn't represent an actual
> > > package group, but rather represents one of a number of
> > > IMAGE_FEATURES that are processed explicitly in a .bbclass file,
> > > like "debug-tweaks" or "read-only-rootfs". so what does the above
> > > line mean?
> > 
> > It's not a package group, but then neither are any of the things
> > defined by PACKAGE_GROUP - that variable just specifies one or more
> > packages to be installed when the specified item appears in
> > IMAGE_FEATURES. Perhaps we should just rename the variable; it's a
> > little more internal than some of the other variables we've renamed
> > in the past.
> 
>   oh, i realize it's not a package group, my point was that that line
> seems entirely superfluous since, as with things like "debug-tweaks"
> and "read-only-rootfs", that "image feature" is processed explicitly
> within image.bbclass:
> 
> # IMAGE_FEATURES may contain any available package group
> IMAGE_FEATURES ?= ""
> IMAGE_FEATURES[type] = "list"
> IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs
> package-management"
> 
> # rootfs bootstrap install
> ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",
> "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTRAP}",d)}"
> 
>   the simple solution would seem to be to just delete the line:
> 
> PACKAGE_GROUP_package-management = "${ROOTFS_PKGMANAGE}"
> 
> from core-image.bbclass since it's both unnecessary and misleading.

It's not unnecessary - how else does the actual package manager make it into 
the image when package-management is in IMAGE_FEATURES?

Now, this functionality should definitely be available from image.bbclass; this 
should get fixed with the rework I've proposed in the following bug:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=5424

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  reply	other threads:[~2013-11-17 12:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17  9:19 why is "package-management" defined as a PACKAGE_GROUP? Robert P. J. Day
2013-11-17 11:24 ` Paul Eggleton
2013-11-17 11:30   ` Robert P. J. Day
2013-11-17 12:12     ` Paul Eggleton [this message]
2013-11-17 12:45       ` Robert P. J. Day
2013-11-17 15:04         ` Chris Larson
2013-11-17 15:28           ` Robert P. J. Day
2013-11-17 16:17           ` Robert P. J. Day
2013-11-17 16:38             ` Chris Larson
2013-11-17 16:46               ` Robert P. J. Day
2013-11-18 10:35             ` Paul Eggleton
2013-11-18 11:23               ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13190111.cIECxPcJYb@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=rpjday@crashcourse.ca \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.