All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Scheel <julian@jusst.de>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: tegra_wm8903 dapm_nc_pins
Date: Wed, 19 Oct 2011 17:29:09 +0200	[thread overview]
Message-ID: <1319038149.1720.7.camel@localhost.localdomain> (raw)

Hi,

is there any special reason for the dapm_nc_pins being hardcoded into
tegra_wm8903.c instead of being set through the platform data?
We are currently making up a platform setting for our devices and would
like to have all relevant settings within the platform driver instead of
having to hack the tegra_wm8903-driver with further machine_is_XX()
checks.

So I would suggest to add an entry to the platform data which contains a
list of NC-pins which are then set to nc by the tegra_wm8903 driver on
startup.

Regards,
Julian

             reply	other threads:[~2011-10-19 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 15:29 Julian Scheel [this message]
2011-10-19 16:12 ` tegra_wm8903 dapm_nc_pins Stephen Warren
2011-10-19 16:34   ` Mark Brown
2011-10-20  5:27   ` Julian Scheel
2011-10-20 15:53     ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319038149.1720.7.camel@localhost.localdomain \
    --to=julian@jusst.de \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.