All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: h-fache@ti.com
Cc: joern@lazybastard.org, joern@logfs.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] phram: make kernel boot command line arguments work
Date: Thu, 20 Oct 2011 19:20:20 +0300	[thread overview]
Message-ID: <1319127627.20953.8.camel@sauron> (raw)
In-Reply-To: <1318866038-11781-1-git-send-email-h-fache@ti.com>

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Mon, 2011-10-17 at 17:40 +0200, h-fache@ti.com wrote:

> -static int phram_setup(const char *val, struct kernel_param *kp)
> +static int phram_init_called;
> +static __initdata char phram_paramline[64+12+12];

snip..
> +static int phram_setup(const char *val, struct kernel_param *kp)
> +{

snip..

> +	strlcpy(phram_paramline, val, sizeof(phram_paramline));

Accessing __initdata from non __init function. Please check that your
patch does not introduce a new section mismatch. There is even a kernel
config option to debug these issues.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2011-10-20 16:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 15:40 [PATCH] phram: make kernel boot command line arguments work h-fache
2011-10-18  0:32 ` Jörn Engel
2011-10-18  8:05   ` Fache, Herve
2011-10-20 16:34   ` Artem Bityutskiy
2011-10-20 16:16 ` Artem Bityutskiy
2011-10-21  8:51   ` Fache, Herve
2011-10-25  7:37     ` Artem Bityutskiy
2011-10-25  9:09       ` Fache, Herve
2011-10-25 19:58         ` Jörn Engel
2011-10-29 20:10         ` Artem Bityutskiy
2011-10-20 16:20 ` Artem Bityutskiy [this message]
2011-10-21  8:49   ` Fache, Herve
2011-10-25  7:32     ` Artem Bityutskiy
2011-10-25  9:07       ` Fache, Herve
2011-10-29 20:09 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319127627.20953.8.camel@sauron \
    --to=dedekind1@gmail.com \
    --cc=h-fache@ti.com \
    --cc=joern@lazybastard.org \
    --cc=joern@logfs.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.