From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ashish Chavan Subject: Re: [PATCH v7 1/3] ASoC: da7210: Add support for DAPM Date: Fri, 21 Oct 2011 15:17:26 +0530 Message-ID: <1319190446.24621.158.camel@matrix> References: <1319119369.24621.84.camel@matrix> <20111021085838.GE3513@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from AM1EHSOBE001.bigfish.com (am1ehsobe001.messaging.microsoft.com [213.199.154.204]) by alsa0.perex.cz (Postfix) with ESMTP id 07E2C103A8A for ; Fri, 21 Oct 2011 11:36:18 +0200 (CEST) In-Reply-To: <20111021085838.GE3513@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel , "kuninori.morimoto.gx" , linux-kernel , David@alsa-project.org, Chen , lrg List-Id: alsa-devel@alsa-project.org On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote: > On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote: > > This patch adds support for DAPM covering all inputs and outputs > > as well as ADC and DAC. > > This patch doesn't apply against current code. That's strange! Let me recheck to see if I messed anything. > > > +/* > > + * DAPM Controls > > + * > > + * Current DAPM implementation covers almost all codec components e.g. IOs, > > + * mixers, PGAs,ADC and DAC. > > This explanation would better placed next to the code in the probe - > it's that code which looks out of place in a Linux driver. Only problem with that is the code to enable individual IOs is not at one place and is scattered in the probe(). Should I place all such things in a single block in probe() and put the comment above that? Thanks, -- Ashish (GNU FAN)