From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: [PATCH 3/9] ib_srpt: Fix srpt_alloc_fabric_acl failure case return value Date: Mon, 24 Oct 2011 05:33:36 +0000 Message-ID: <1319434422-15354-4-git-send-email-nab@linux-iscsi.org> References: <1319434422-15354-1-git-send-email-nab@linux-iscsi.org> Return-path: In-Reply-To: <1319434422-15354-1-git-send-email-nab@linux-iscsi.org> Sender: target-devel-owner@vger.kernel.org To: target-devel , linux-rdma Cc: linux-scsi , Roland Dreier , Bart Van Assche , Nicholas Bellinger List-Id: linux-rdma@vger.kernel.org From: Nicholas Bellinger This patch fixes a bug in srpt_make_nodeacl(), where a failure of srpt_alloc_fabric_acl() was not setting a proper error return code. Reported-by: Bart Van Assche Cc: Bart Van Assche Cc: Roland Dreier Signed-off-by: Nicholas A. Bellinger --- drivers/infiniband/ulp/srpt/ib_srpt.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 6aba709..fee78b0 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -3679,8 +3679,10 @@ static struct se_node_acl *srpt_make_nodeacl(struct se_portal_group *tpg, } se_nacl_new = srpt_alloc_fabric_acl(tpg); - if (!se_nacl_new) + if (!se_nacl_new) { + ret = -ENOMEM; goto err; + } /* * nacl_new may be released by core_tpg_add_initiator_node_acl() * when converting a node ACL from demo mode to explict -- 1.7.2.5