Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

["Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>]

On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote:
> On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger
> <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org> wrote:
> > +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size(
> > +       struct se_portal_group *se_tpg,
> > +       const char *page,
> > +       size_t count)
> > +{
> > +       struct srpt_port *sport = container_of(se_tpg, struct srpt_port, port_tpg_1);
> > +       unsigned long val;
> > +       int ret;
> > +
> > +       ret = strict_strtoul(page, 0, &val);
> 
> If the data "page" points at only consists of digits, the above
> strict_strtoul() call will trigger a past-end-of-buffer read.

I don't understand what you mean here.  Can you provide a test case to
demonstrate please..?

> Also, isn't kstrto*() preferred over strict_strto*() ?
> 

Not AFAIK.

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html