All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Benoît Canet" <benoit.canet@gmail.com>
Subject: [Qemu-devel] [PATCH 05/15] syborg_keyboard: convert to memory API
Date: Mon, 24 Oct 2011 23:03:31 +0200	[thread overview]
Message-ID: <1319490221-5854-7-git-send-email-benoit.canet@gmail.com> (raw)
In-Reply-To: <1319490221-5854-1-git-send-email-benoit.canet@gmail.com>

Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
---
 hw/syborg_keyboard.c |   28 +++++++++++-----------------
 1 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/hw/syborg_keyboard.c b/hw/syborg_keyboard.c
index 82b9dc0..03d2183 100644
--- a/hw/syborg_keyboard.c
+++ b/hw/syborg_keyboard.c
@@ -51,6 +51,7 @@ enum {
 
 typedef struct {
     SysBusDevice busdev;
+    MemoryRegion iomem;
     uint32_t int_enabled;
     int extension_bit;
     uint32_t fifo_size;
@@ -66,7 +67,8 @@ static void syborg_keyboard_update(SyborgKeyboardState *s)
     qemu_set_irq(s->irq, level);
 }
 
-static uint32_t syborg_keyboard_read(void *opaque, target_phys_addr_t offset)
+static uint64_t syborg_keyboard_read(void *opaque, target_phys_addr_t offset,
+                                    unsigned size)
 {
     SyborgKeyboardState *s = (SyborgKeyboardState *)opaque;
     int c;
@@ -104,7 +106,7 @@ static uint32_t syborg_keyboard_read(void *opaque, target_phys_addr_t offset)
 }
 
 static void syborg_keyboard_write(void *opaque, target_phys_addr_t offset,
-                                  uint32_t value)
+                                  uint64_t value, unsigned size)
 {
     SyborgKeyboardState *s = (SyborgKeyboardState *)opaque;
 
@@ -121,16 +123,10 @@ static void syborg_keyboard_write(void *opaque, target_phys_addr_t offset,
     }
 }
 
-static CPUReadMemoryFunc * const syborg_keyboard_readfn[] = {
-     syborg_keyboard_read,
-     syborg_keyboard_read,
-     syborg_keyboard_read
-};
-
-static CPUWriteMemoryFunc * const syborg_keyboard_writefn[] = {
-     syborg_keyboard_write,
-     syborg_keyboard_write,
-     syborg_keyboard_write
+static const MemoryRegionOps syborg_keyboard_ops = {
+    .read = syborg_keyboard_read,
+    .write = syborg_keyboard_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
 };
 
 static void syborg_keyboard_event(void *opaque, int keycode)
@@ -184,13 +180,11 @@ static const VMStateDescription vmstate_syborg_keyboard = {
 static int syborg_keyboard_init(SysBusDevice *dev)
 {
     SyborgKeyboardState *s = FROM_SYSBUS(SyborgKeyboardState, dev);
-    int iomemtype;
 
     sysbus_init_irq(dev, &s->irq);
-    iomemtype = cpu_register_io_memory(syborg_keyboard_readfn,
-                                       syborg_keyboard_writefn, s,
-                                       DEVICE_NATIVE_ENDIAN);
-    sysbus_init_mmio(dev, 0x1000, iomemtype);
+    memory_region_init_io(&s->iomem, &syborg_keyboard_ops, s,
+                              "keyboard", 0x1000);
+    sysbus_init_mmio_region(dev, &s->iomem);
     if (s->fifo_size <= 0) {
         fprintf(stderr, "syborg_keyboard: fifo too small\n");
         s->fifo_size = 16;
-- 
1.7.4.1

  parent reply	other threads:[~2011-10-24 21:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 21:03 [Qemu-devel] (no subject) Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH V2 00/15] V2 arm: more memory API and VMState conversion Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 01/15] marvell_88x8618_audio: convert to memory API Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 02/15] mst_fpga: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 03/15] syborg_fb: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 04/15] syborg_interrupt: " Benoît Canet
2011-10-24 21:03 ` Benoît Canet [this message]
2011-10-24 21:03 ` [Qemu-devel] [PATCH 06/15] syborg_pointer: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 07/15] syborg_rtc: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 08/15] syborg_serial: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 09/15] syborg_timer: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 10/15] syborg_virtio: " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 11/15] pl181: add vmstate Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 12/15] bitbang_i2c: convert to VMState Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 13/15] realview: convert realview i2c " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 14/15] integratorcp: convert integratorcm " Benoît Canet
2011-10-24 21:03 ` [Qemu-devel] [PATCH 15/15] integratorcp: convert icp_pic " Benoît Canet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319490221-5854-7-git-send-email-benoit.canet@gmail.com \
    --to=benoit.canet@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.