From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: David Ahern <dsahern@gmail.com>
Cc: Deng-Cheng Zhu <dczhu@mips.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [RFC PATCH 1/2] tools/perf: Don't set attr->disabled when doing grouping
Date: Tue, 25 Oct 2011 09:26:23 +0200 [thread overview]
Message-ID: <1319527583.13128.9.camel@laptop> (raw)
In-Reply-To: <4EA573E4.3090408@gmail.com>
On Mon, 2011-10-24 at 08:19 -0600, David Ahern wrote:
>
> Seems like a bug with the group checks. You should be able to enable and
> disable events - including creating them disabled.
Agreed, it makes no sense to allow creating a group you can't use.
next prev parent reply other threads:[~2011-10-25 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 10:56 [RFC PATCH 0/2] tools/perf: fix the event grouping functionality Deng-Cheng Zhu
2011-10-24 10:56 ` [RFC PATCH 1/2] tools/perf: Don't set attr->disabled when doing grouping Deng-Cheng Zhu
2011-10-24 14:19 ` David Ahern
2011-10-25 7:26 ` Peter Zijlstra [this message]
2011-10-24 10:57 ` [RFC PATCH 2/2] tools/perf: Make group_fd static and move its place in __perf_evsel__open() Deng-Cheng Zhu
2011-10-24 14:03 ` Arnaldo Carvalho de Melo
2011-10-25 15:23 ` Arnaldo Carvalho de Melo
2011-10-26 6:26 ` Deng-Cheng Zhu
2011-10-26 11:18 ` Arnaldo Carvalho de Melo
2011-10-26 11:21 ` Arnaldo Carvalho de Melo
2011-10-26 13:14 ` Zhu, DengCheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319527583.13128.9.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=dczhu@mips.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.