Re: [GIT PULL] target: Updates for v3.2-rc1 (round one)

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Tue, 2011-10-25 at 11:44 +0200, Linus Torvalds wrote:
> On Tue, Oct 25, 2011 at 11:29 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Hmm. This is not what I get. It might be a git version issue or diff
> > algorithm one - although that's actually pretty unusual. Do you do
> > something odd/special?
> 
> Another question: you picked a very particular and odd place to start
> development. It's commit 65112dccf8a ("Merge
> git://git.samba.org/sfrench/cifs-2.6") which just *seems* to be some
> "random Linux tree kernel of the day". I'm not seeing why you picked
> that one.
> 
> This is not a deal-breaker, and *please* don't use this as an argument
> for rebasing (quite the opposite), but it's basically a note to ask
> you to just pick a better starting point next time. It's usually much
> better to start from an actual release (preferably a *real* release,
> like 3.0) than from a "random daily tree". Of course, using an -rc1
> release is usually a really bad idea also, but in the rough timeframe
> we're talking about (October 10 - two weeks ago - that's apparently
> when you started worrying about this next merge window) you could have
> at least picked something like -rc9 as the base.
> 
> So basically, I'm asking that people not rebase, but also spend a bit
> of time thinking about "where should I start development".
> 

Point understood.   I'll make sure to pick a tagged -rc release for the
target-pending.git base next time.

Thank you,

--nab