From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute Date: Tue, 25 Oct 2011 03:35:53 -0700 Message-ID: <1319538953.20828.0.camel@haakon2.linux-iscsi.org> References: <1319434422-15354-1-git-send-email-nab@linux-iscsi.org> <1319434422-15354-8-git-send-email-nab@linux-iscsi.org> <1319488195.17450.73.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche Cc: linux-rdma , Roland Dreier , Christoph Hellwig , target-devel , linux-scsi List-Id: linux-rdma@vger.kernel.org On Tue, 2011-10-25 at 12:32 +0200, Bart Van Assche wrote: > On Mon, Oct 24, 2011 at 10:29 PM, Nicholas A. Bellinger > wrote: > >> @@ -114,6 +114,7 @@ enum { > >> MIN_SRPT_SRQ_SIZE = 4, > >> DEFAULT_SRPT_SRQ_SIZE = 4095, > >> MAX_SRPT_SRQ_SIZE = 65535, > >> + MAX_SRPT_RDMA_SIZE = 256U, > >> > > > > Hey btw, what should the proper MAX_SRPT_RDMA_SIZE be here..? > > As you can see in the ib_srpt source code, the largest value filled in > for this parameter in the IOC profile is 1U << 24. Thanks Bart. Fixing this up now. --nab -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html