All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi
Subject: Re: [PATCH 2/2] Bluetooth: bcm203x: Use GFP_KERNEL in workqueue
Date: Wed, 26 Oct 2011 10:54:10 +0200	[thread overview]
Message-ID: <1319619251.15441.250.camel@aeonflux> (raw)
In-Reply-To: <1319570016-7439-2-git-send-email-dh.herrmann@googlemail.com>

Hi David,

> A workqueue is allowed to sleep so we can safely use GFP_KERNEL instead of
> GFP_ATOMIC. This is still legacy code when the driver used timer BHs and not a
> worqueue.
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
>  drivers/bluetooth/bcm203x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

good catch here. We should not use GFP_ATOMIC until we have to.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  reply	other threads:[~2011-10-26  8:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25 19:13 [PATCH 1/2] Bluetooth: bcm203x: Fix race condition on disconnect David Herrmann
2011-10-25 19:13 ` [PATCH 2/2] Bluetooth: bcm203x: Use GFP_KERNEL in workqueue David Herrmann
2011-10-26  8:54   ` Marcel Holtmann [this message]
2011-10-31 19:55   ` Gustavo Padovan
2011-10-26  8:57 ` [PATCH 1/2] Bluetooth: bcm203x: Fix race condition on disconnect Marcel Holtmann
2011-10-26  9:03   ` David Herrmann
2011-10-26  9:04     ` Marcel Holtmann
2011-10-26  9:13       ` [PATCH v2] " David Herrmann
2011-10-26  9:16         ` Marcel Holtmann
2011-10-31 19:54         ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319619251.15441.250.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=dh.herrmann@googlemail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.