From: Davidlohr Bueso <dave@gnu.org>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: [PATCH 1/2] partx: remove __NCOLUMNS
Date: Wed, 26 Oct 2011 15:57:38 +0200 [thread overview]
Message-ID: <1319637458.3771.11.camel@offworld> (raw)
From: Davidlohr Bueso <dave@gnu.org>
We use ARRAY_SIZE() instead to define the amount of available columns.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
partx/partx.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/partx/partx.c b/partx/partx.c
index bf18a4e..b12eebc 100644
--- a/partx/partx.c
+++ b/partx/partx.c
@@ -49,7 +49,6 @@ enum {
COL_TYPE,
COL_FLAGS,
COL_SCHEME,
- __NCOLUMNS
};
enum {
@@ -72,7 +71,7 @@ struct colinfo {
};
/* columns descriptions */
-struct colinfo infos[__NCOLUMNS] = {
+struct colinfo infos[] = {
[COL_PARTNO] = { "NR", 0.25, TT_FL_RIGHT, N_("partition number") },
[COL_START] = { "START", 0.30, TT_FL_RIGHT, N_("start of the partition in sectors") },
[COL_END] = { "END", 0.30, TT_FL_RIGHT, N_("end of the partition in sectors") },
@@ -84,8 +83,11 @@ struct colinfo infos[__NCOLUMNS] = {
[COL_FLAGS] = { "FLAGS", 0.1, TT_FL_TRUNC, N_("partition flags")},
[COL_TYPE] = { "TYPE", 1, TT_FL_RIGHT, N_("partition type hex or uuid")},
};
+
+#define NCOLS ARRAY_SIZE(infos)
+
/* array with IDs of enabled columns */
-static int columns[__NCOLUMNS], ncolumns;
+static int columns[NCOLS], ncolumns;
static int verbose;
static int partx_flags;
@@ -137,9 +139,9 @@ static void assoc_loopdev(const char *fname)
static inline int get_column_id(int num)
{
- assert(ARRAY_SIZE(columns) == __NCOLUMNS);
+ assert(ARRAY_SIZE(columns) == NCOLS);
assert(num < ncolumns);
- assert(columns[num] < __NCOLUMNS);
+ assert(columns[num] < NCOLS);
return columns[num];
}
@@ -154,7 +156,7 @@ static int column_name_to_id(const char *name, size_t namesz)
assert(name);
- for (i = 0; i < __NCOLUMNS; i++) {
+ for (i = 0; i < NCOLS; i++) {
const char *cn = infos[i].name;
if (!strncasecmp(name, cn, namesz) && !*(cn + namesz))
@@ -624,7 +626,7 @@ static void __attribute__((__noreturn__)) usage(FILE *out)
fputs(_("\nAvailable columns (for --show, --raw or --pairs):\n"), out);
- for (i = 0; i < __NCOLUMNS; i++)
+ for (i = 0; i < NCOLS; i++)
fprintf(out, " %10s %s\n", infos[i].name, _(infos[i].help));
fprintf(out, _("\nFor more information see partx(8).\n"));
--
1.7.7
next reply other threads:[~2011-10-26 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 13:57 Davidlohr Bueso [this message]
2011-11-02 15:19 ` [PATCH 1/2] partx: remove __NCOLUMNS Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319637458.3771.11.camel@offworld \
--to=dave@gnu.org \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.