Re: [PATCH 0/7] New meta-romley BSP created.

[Tom Zanussi <tom.zanussi@intel.com>]

On Wed, 2011-10-26 at 16:25 -0700, Bodke, Kishore K wrote:
> From: Kishore Bodke <kishore.k.bodke@intel.com>
> 
> Hi All,
> 
> 
> This layer provides  new BSP meta-romley and tested against the master branch.
> This provides the support for Romley + Patsburg Chipset for Intel Systems.
> Romley refers to the Intel Rosecity Board.
> This has been verified by Tom Zanussi, and wanted to pull this BSP into the 
> main line.
> 
> Please let me know if anything is required further to get into the main line.
> 
> Please pull.
> 

Hi Kishore,

In general it looks ok, but one thing that's missing is a Signed-off-by:
for each of your patches.  You can have them added automatically by
using -s with 'git commit'.

Also, several of the commits are missing comments, especially the first
one containing the bulk of the BSP - these are needed so we can see what
each patch does when looking at the git history.  You can see examples
of what the comments look like for previous commits by doing a 'git
log'.

Also, we normally don't want to see the gory details of each commit you
made when developing the BSP - if there's a logical set of commits that
progressively add functionality and each makes sense on its own that's
fine, but things that just fix up problems in previous patches should
typically be squashed into those previous patches.  For example, the
final two patches in this series essentially back out changes added by
previous patches.  You can use 'git rebase -i' to do that as well as the
other changes mentioned.

Thanks,

Tom

> Thanks
> Kishore.
> 
> 
> The following changes since commit b5c9f0af18b80c2b4c478fd7cfb537e0a04a4e22:
> 
>   meta-fri2: README correction (2011-10-25 14:52:36 -0500)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/meta-intel-contrib master0
>   http://git.pokylinux.org/cgit.cgi/meta-intel-contrib/log/?h=master0
> 
> Kishore Bodke (3):
>   New Romley BSP added.
>   Romley BSP tested against master branch and with new xorg changes.
>   Updated the romley.conf and removed linux-yocto_2.6.37.bbappend file.
>         Signed-off-by: Kishore Bodke <kishore.k.bodke@intel.com>
> 
> Tom Zanussi (4):
>   meta-romley: remove meta-intel/common from BBFILES
>   meta-romley: xserver-xorg renaming updates
>   add enable-dga to the xserver to get rid of DGAInit startup error
>   add missing xaa module
> 
>  MAINTAINERS                                        |    4 +
>  meta-romley/COPYING.MIT                            |   17 ++++
>  meta-romley/README                                 |   86 ++++++++++++++++++++
>  meta-romley/README.sources                         |   17 ++++
>  meta-romley/conf/layer.conf                        |   10 +++
>  meta-romley/conf/machine/romley.conf               |   46 +++++++++++
>  .../formfactor/formfactor/romley/machconfig        |    3 +
>  .../recipes-bsp/formfactor/formfactor_0.0.bbappend |    3 +
>  .../recipes-core/tasks/task-core-tools.bbappend    |    2 +
>  .../xorg-driver/xf86-video-mga_1.4.13.bb           |   19 +++++
>  .../xserver-xf86-config/romley/xorg.conf           |   26 ++++++
>  .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    3 +
>  .../xorg-xserver/xserver-xorg_1.11.1.bbappend      |    1 +
>  .../linux/linux-yocto-rt_3.0.bbappend              |    8 ++
>  .../recipes-kernel/linux/linux-yocto_3.0.bbappend  |    7 ++
>  meta-sugarbay/conf/machine/sugarbay.conf           |    4 +-
>  16 files changed, 253 insertions(+), 3 deletions(-)
>  create mode 100644 meta-romley/COPYING.MIT
>  create mode 100644 meta-romley/README
>  create mode 100644 meta-romley/README.sources
>  create mode 100644 meta-romley/binary/.gitignore
>  create mode 100644 meta-romley/conf/layer.conf
>  create mode 100644 meta-romley/conf/machine/romley.conf
>  create mode 100644 meta-romley/recipes-bsp/formfactor/formfactor/romley/machconfig
>  create mode 100644 meta-romley/recipes-bsp/formfactor/formfactor_0.0.bbappend
>  create mode 100644 meta-romley/recipes-core/tasks/task-core-tools.bbappend
>  create mode 100755 meta-romley/recipes-graphics/xorg-driver/xf86-video-mga_1.4.13.bb
>  create mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config/romley/xorg.conf
>  create mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
>  create mode 100644 meta-romley/recipes-graphics/xorg-xserver/xserver-xorg_1.11.1.bbappend
>  create mode 100644 meta-romley/recipes-kernel/linux/linux-yocto-rt_3.0.bbappend
>  create mode 100644 meta-romley/recipes-kernel/linux/linux-yocto_3.0.bbappend
>