All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm: do not sleep on vblank while holding a mutex
Date: Fri, 28 Oct 2011 08:59:04 +0200	[thread overview]
Message-ID: <1319785144.7162.14.camel@thor.local> (raw)
In-Reply-To: <Pine.GSO.4.62.1110272126130.19911@umail>

On Don, 2011-10-27 at 22:19 -0500, Ilija Hadzic wrote: 
> On Thu, 27 Oct 2011, Daniel Vetter wrote:
> 
> > So I think the right thing to do is
> > - Kill dev->last_vblank_wait (in a prep patch).
> 
> Agreed. Also drm_vblank_info function can go away

Actually, I was rather going to submit a patch to hook it up again —
AFAICT it was unhooked without any justification. It could be useful for
debugging vblank related hangs. Any issues with it, such as
last_vblank_wait not being guaranteed to really be the last one, can
always be improved later on.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2011-10-28  6:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26  2:20 drm: fix one flawed mutex grab and remove some spurious mutex grabs Ilija Hadzic
2011-10-26  2:20 ` [PATCH 1/3] drm: no need to hold global mutex for static data Ilija Hadzic
2011-10-26  7:44   ` Daniel Vetter
2011-10-26  2:20 ` [PATCH 2/3] drm: make DRM_UNLOCKED ioctls with their own mutex Ilija Hadzic
2011-10-26  7:47   ` Daniel Vetter
2011-10-26 16:11     ` Ilija Hadzic
2011-10-26 20:01       ` Daniel Vetter
2011-10-26  2:20 ` [PATCH 3/3] drm: do not sleep on vblank while holding a mutex Ilija Hadzic
2011-10-26  7:54   ` Daniel Vetter
2011-10-26 22:33     ` Ilija Hadzic
2011-10-27 10:43       ` Daniel Vetter
2011-10-27 14:10         ` Alan Coopersmith
2011-10-27 14:20           ` Ilija Hadzic
2011-10-28  3:19         ` Ilija Hadzic
2011-10-28  4:36           ` Ilija Hadzic
2011-10-28  6:59           ` Michel Dänzer [this message]
2011-10-28  9:20             ` Daniel Vetter
2011-10-28 12:10               ` Ilija Hadzic
2011-10-28 14:51                 ` Daniel Vetter
2011-10-28  9:30           ` Daniel Vetter
2011-10-26  8:02   ` Michel Dänzer
2011-10-26 22:50     ` Ilija Hadzic
     [not found] <mailman.37.1319803862.23620.dri-devel@lists.freedesktop.org>
2011-10-28 18:15 ` Mario Kleiner
2011-10-28 19:15   ` Daniel Vetter
2011-10-28 19:53     ` Mario Kleiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319785144.7162.14.camel@thor.local \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ihadzic@research.bell-labs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.