All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace
Date: Fri, 28 Oct 2011 09:55:27 +0100	[thread overview]
Message-ID: <1319792127.22423.1.camel@ted> (raw)
In-Reply-To: <1319743874-9891-1-git-send-email-msm@freescale.com>

On Thu, 2011-10-27 at 14:31 -0500, Matthew McClintock wrote:
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> v2: Change to use PACKAGES_prepend instead of explictly listing all packages
> and also fixing the fact we missed the -dev and -dbg packages before
> 
>  meta/recipes-devtools/strace/strace_4.5.20.bb |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-devtools/strace/strace_4.5.20.bb b/meta/recipes-devtools/strace/strace_4.5.20.bb
> index b3d2aa5..450abea 100644
> --- a/meta/recipes-devtools/strace/strace_4.5.20.bb
> +++ b/meta/recipes-devtools/strace/strace_4.5.20.bb
> @@ -5,7 +5,9 @@ LICENSE = "BSD"
>  LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=4535377ede62550fdeaf39f595fd550a"
>  PR = "r2"
>  
> -RDEPENDS = "perl"
> +PACKAGES_prepend = "${PN}-graph "
> +FILES_${PN}-graph = "${bindir}/strace-graph"
> +RDEPENDS_${PN}-graph = "perl"

I should have been clearer in my original email, pretty much every other
recipe uses += or =+ in this context. Whilst the _prepend override is
probably ok, its probably a bit heavy in this case and the standard
operator should work just fine.

Cheers,

Richard




  reply	other threads:[~2011-10-28  9:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-27  5:14 [PATCH 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace Matthew McClintock
2011-10-27  5:14 ` [PATCH 2/2] Add new util-linux-chkdupexe package to avoid making perl a dependecy for all of util-linux Matthew McClintock
2011-10-27  7:32   ` Richard Purdie
2011-10-27  7:26 ` [PATCH 1/2] Add new strace-graph package to avoid making perl a dependecy for all of strace Richard Purdie
2011-10-27 19:31   ` [PATCH v2 " Matthew McClintock
2011-10-28  8:55     ` Richard Purdie [this message]
2011-10-28 15:34       ` McClintock Matthew-B29882
2011-10-28 15:54         ` Phil Blundell
2011-10-28 20:07           ` McClintock Matthew-B29882
2011-10-31  9:05             ` Paul Eggleton
2011-10-31 16:26               ` [PATCH v3 " Matthew McClintock
2011-11-02  0:35                 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319792127.22423.1.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.