All of lore.kernel.org
 help / color / mirror / Atom feed
From: svens@stackframe.org (Sven Schnelle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ATMEL USB: pass unknown FEATURE SET requests to gadget
Date: Fri, 28 Oct 2011 11:44:16 +0200	[thread overview]
Message-ID: <1319795056-8286-1-git-send-email-svens@stackframe.org> (raw)

When using the dbgp gadget with the atmel usb controller, the following
message is logged:

udc: ep0: Invalid setup request: 00.03 v0006 i0000 l0, halting endpoint...

That makes the gadget unusable with the atmel usba controller driver. Fix this
by passing unknown request to the gadget driver.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
---
 drivers/usb/gadget/atmel_usba_udc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
index 271a9d8..49480493 100644
--- a/drivers/usb/gadget/atmel_usba_udc.c
+++ b/drivers/usb/gadget/atmel_usba_udc.c
@@ -1310,7 +1310,7 @@ static int handle_ep0_setup(struct usba_udc *udc, struct usba_ep *ep,
 			} else if (feature_is_dev_remote_wakeup(crq)) {
 				udc->devstatus |= 1 << USB_DEVICE_REMOTE_WAKEUP;
 			} else {
-				goto stall;
+				goto delegate;
 			}
 		} else if (crq->bRequestType == USB_RECIP_ENDPOINT) {
 			struct usba_ep *target;
-- 
1.7.6.3

                 reply	other threads:[~2011-10-28  9:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319795056-8286-1-git-send-email-svens@stackframe.org \
    --to=svens@stackframe.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.