From: Artem Bityutskiy <dedekind1@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Roland Kletzing <devzero@web.de>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: mark tests EXPERIMENTAL
Date: Sat, 29 Oct 2011 23:30:05 +0300 [thread overview]
Message-ID: <1319920207.2126.19.camel@koala> (raw)
In-Reply-To: <1319533791-32605-2-git-send-email-w.sang@pengutronix.de>
On Tue, 2011-10-25 at 11:09 +0200, Wolfram Sang wrote:
> The tests may erase mtd devices, so mark them EXPERIMENTAL and emphasize
> this fact in the Kconfig entry, so users will think twice before running
> them.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mtd/Kconfig | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 4be8373..81d9b92 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -27,12 +27,15 @@ config MTD_DEBUG_VERBOSE
>
> config MTD_TESTS
> tristate "MTD tests support"
> - depends on m
> + depends on m && EXPERIMENTAL
> help
> This option includes various MTD tests into compilation. The tests
> should normally be compiled as kernel modules. The modules perform
> various checks and verifications when loaded.
>
> + WARNING: Some of the tests will ERASE THE CONTENT of mtd devices!
> + Do not use these tests unless you are sure you really need to.
> +
I am OK with this close, but I am not sure about the EXPERIMENTAL. I
though this is used for the code which is considered to be "not ready"
for real use, while the tests work well.
Artem.
next prev parent reply other threads:[~2011-10-29 20:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 9:09 [PATCH 1/2] mtd: tests: don't use mtd0 as a default Wolfram Sang
2011-10-25 9:09 ` [PATCH 2/2] mtd: mark tests EXPERIMENTAL Wolfram Sang
2011-10-29 20:30 ` Artem Bityutskiy [this message]
2011-10-29 20:40 ` Wolfram Sang
2011-10-30 12:29 ` Artem Bityutskiy
2011-10-30 16:28 ` [PATCH V2 2/2] mtd: tests: annotate as DANGEROUS in Kconfig Wolfram Sang
2011-10-30 20:34 ` Artem Bityutskiy
2011-10-30 20:37 ` Wolfram Sang
2011-10-31 17:00 ` Brian Norris
2011-11-08 20:35 ` Artem Bityutskiy
2011-10-25 11:34 ` [PATCH 1/2] mtd: tests: don't use mtd0 as a default Artem Bityutskiy
2011-10-29 20:25 ` Artem Bityutskiy
2011-10-29 20:28 ` Wolfram Sang
2011-10-29 20:35 ` Artem Bityutskiy
2011-10-29 20:56 ` [PATCH V2 " Wolfram Sang
2011-10-29 21:12 ` Artem Bityutskiy
2011-10-29 22:11 ` [PATCH V3 " Wolfram Sang
2011-10-30 12:32 ` Artem Bityutskiy
2011-10-30 12:24 ` [PATCH V2 " Artem Bityutskiy
2011-11-02 22:11 ` [PATCH " Roland Kletzing
2011-10-29 20:28 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319920207.2126.19.camel@koala \
--to=dedekind1@gmail.com \
--cc=devzero@web.de \
--cc=linux-mtd@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.