From: Luciano Coelho <coelho@ti.com>
To: guy@wizery.com
Cc: linux-wireless@vger.kernel.org, eliad@wizery.com
Subject: Re: [PATCH] wl12xx: set scan probe requests rate according to the no_cck flag
Date: Mon, 31 Oct 2011 11:36:57 +0200 [thread overview]
Message-ID: <1320053817.2672.1.camel@cumari> (raw)
In-Reply-To: <CAB3XZEdk2pxH4k4tYXn44Sdb8STdXEh7VVsE85__e=M2Fk9s7A@mail.gmail.com>
On Sun, 2011-10-16 at 12:58 +0200, Eliad Peller wrote:
> hi Guy,
>
> On Sat, Oct 15, 2011 at 10:23 PM, Guy Eilam <guy@wizery.com> wrote:
> > Set the TX rate of probe requests during scanning according to the
> > no_cck flag in the scan request struct.
> >
> > Signed-off-by: Guy Eilam <guy@wizery.com>
> > ---
> [...]
>
> > @@ -243,7 +242,12 @@ void wl1271_scan_stm(struct wl1271 *wl)
> >
> > case WL1271_SCAN_STATE_2GHZ_ACTIVE:
> > band = IEEE80211_BAND_2GHZ;
> > - rate = wl1271_tx_min_rate_get(wl, wl->bitrate_masks[band]);
> > + if (wl->scan.req->no_cck)
> > + rate = wl1271_tx_min_rate_get(wl,
> > + CONF_TX_RATE_MASK_BASIC_P2P);
> > + else
> > + rate = wl1271_tx_min_rate_get(wl,
> > + CONF_TX_RATE_MASK_BASIC);
>
> on a second thought, this seems a bit wrong.
> i think we should consider the configured bitrate_masks when scanning.
> maybe just mask-out the cck rates?
Any follow up on this?
--
Cheers,
Luca.
prev parent reply other threads:[~2011-10-31 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 20:23 [PATCH] wl12xx: set scan probe requests rate according to the no_cck flag Guy Eilam
2011-10-16 10:58 ` Eliad Peller
2011-10-31 9:36 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320053817.2672.1.camel@cumari \
--to=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=guy@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.