From: Asias He <asias.hejun@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Sasha Levin <levinsasha928@gmail.com>,
kvm@vger.kernel.org, Asias He <asias.hejun@gmail.com>
Subject: [PATCH 5/5] kvm tools: Remove dead code virt_queue__trigger_irq()
Date: Mon, 31 Oct 2011 22:39:42 +0800 [thread overview]
Message-ID: <1320071982-21560-5-git-send-email-asias.hejun@gmail.com> (raw)
In-Reply-To: <1320071982-21560-1-git-send-email-asias.hejun@gmail.com>
This function is not used anymore. Instead, We are using
virtio_pci__signal_vq() to trigger interrupt right now.
Signed-off-by: Asias He <asias.hejun@gmail.com>
---
tools/kvm/include/kvm/virtio.h | 3 ---
tools/kvm/virtio/core.c | 12 ------------
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/tools/kvm/include/kvm/virtio.h b/tools/kvm/include/kvm/virtio.h
index 3442338..c6c380d 100644
--- a/tools/kvm/include/kvm/virtio.h
+++ b/tools/kvm/include/kvm/virtio.h
@@ -57,9 +57,6 @@ u16 virt_queue__get_iov(struct virt_queue *queue, struct iovec iov[], u16 *out,
u16 virt_queue__get_inout_iov(struct kvm *kvm, struct virt_queue *queue,
struct iovec in_iov[], struct iovec out_iov[],
u16 *in, u16 *out);
-
-void virt_queue__trigger_irq(struct virt_queue *vq, int irq, u8 *isr, struct kvm *kvm);
-
int virtio__get_dev_specific_field(int offset, bool msix, bool features_hi, u32 *config_off);
#endif /* KVM__VIRTIO_H */
diff --git a/tools/kvm/virtio/core.c b/tools/kvm/virtio/core.c
index d7c132b..0466e07 100644
--- a/tools/kvm/virtio/core.c
+++ b/tools/kvm/virtio/core.c
@@ -89,18 +89,6 @@ u16 virt_queue__get_inout_iov(struct kvm *kvm, struct virt_queue *queue,
return head;
}
-
-void virt_queue__trigger_irq(struct virt_queue *vq, int irq, u8 *isr, struct kvm *kvm)
-{
- if (vq->vring.avail->flags & VRING_AVAIL_F_NO_INTERRUPT)
- return;
-
- if (*isr == VIRTIO_IRQ_LOW) {
- *isr = VIRTIO_IRQ_HIGH;
- kvm__irq_line(kvm, irq, VIRTIO_IRQ_HIGH);
- }
-}
-
int virtio__get_dev_specific_field(int offset, bool msix, bool features_hi, u32 *config_off)
{
if (msix) {
--
1.7.7.1
prev parent reply other threads:[~2011-10-31 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 14:39 [PATCH 1/5] kvm tools: Drop unused variable in struct uip_buf Asias He
2011-10-31 14:39 ` [PATCH 2/5] kvm tools: Use macro in uip_tx_do_ipv4() Asias He
2011-10-31 14:39 ` [PATCH 3/5] kvm tools: Fix a vertical indentation for net/uip/udp.c Asias He
2011-10-31 14:39 ` [PATCH 4/5] kvm tools: Fix ndev mutex and condition variable initialization Asias He
2011-10-31 14:39 ` Asias He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320071982-21560-5-git-send-email-asias.hejun@gmail.com \
--to=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.