From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2] dbus: fix for right owner in postinst
Date: Tue, 01 Nov 2011 14:15:37 +0000 [thread overview]
Message-ID: <1320156937.15387.6.camel@ted> (raw)
In-Reply-To: <CA+chaQc0zDHUENEkxOqNER5n+E6hvxNM-KgedE31thQBMY+uFA@mail.gmail.com>
On Tue, 2011-11-01 at 14:36 +0100, Martin Jansa wrote:
> On Mon, Oct 31, 2011 at 11:40 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Mon, 2011-10-31 at 18:43 +0100, Martin Jansa wrote:
> >> * even when I see right chown/chmod in log.do_install, files are still
> >> owned by bitbake:bitbake (user running bitbake) and we need to fix it on target
> >> $ tail -n 4 temp/log.do_install.27768
> >> + chown messagebus:messagebus /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/var/run/dbus /OE/shr-core/tmp/work/armv7a-vfp-neon-o
> >> e-linux-gnueabi/dbus-1.4.12-r2/image/var/lib/dbus
> >> + chown root:messagebus /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-helper
> >> + chmod 4754 /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-helper
> >> + ln -sf /dev/null /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image//lib/systemd/system/dbus-1.service
> >>
> >> $ ll -d /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/var/run/dbus \
> >> /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/var/lib/dbus \
> >> /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-helper \
> >> /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-helper
> >> -rwsr-xr-- 1 bitbake bitbake 819869 Oct 29 12:35 /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-he
> >> lper*
> >> -rwsr-xr-- 1 bitbake bitbake 819869 Oct 29 12:35 /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/usr/libexec/dbus-daemon-launch-he
> >> lper*
> >> drwxr-xr-x 2 bitbake bitbake 4096 Oct 29 12:35 /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/var/lib/dbus/
> >> drwxr-xr-x 2 bitbake bitbake 4096 Oct 29 12:35 /OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image/var/run/dbus/
> >>
> >> * and we _cannot_ use ${D} in postinst script because it get's expanded
> >> before including postinst file to ipk's control.tar.gz
> >> and on target I see something like this:
> >> if [ -z "/OE/shr-core/tmp/work/armv7a-vfp-neon-oe-linux-gnueabi/dbus-1.4.12-r2/image" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> >> which is wrong $D without {} works
> >>
> >> * V2: updated with Otavio version to fix it also for do_rootfs
> >>
> >> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> >> ---
> >> meta/recipes-core/dbus/dbus.inc | 12 +++++-------
> >> 1 files changed, 5 insertions(+), 7 deletions(-)
> >
> > This is just wallpapering over the cracks I'm afraid. There is something
> > more fundamental going wrong here and we need to track it down...
>
> Is pseudo really supposed to allow chown in do_install()? And then ie
> keep changed owners in sysroot or even sstate to recreate packages
> later with right file owners?
Yes, it is.
> Because normally all produced files are owned by UID who is building
> them (in my example bitbake) and only when creating packages/rootfs
> it's packaged with expected UID for target (ie root).
I appreciate that.
> So this wallpapering makes current dbus at least usable on target.
This doesn't mean the fix is correct though. I have a patch series to
fix the real issues (there are several) that will be published shortly.
Cheers,
Richard
prev parent reply other threads:[~2011-11-01 14:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 20:30 Trouble by last dbus patch (46e6c3fa8034b12d178d605f3f5d7efe69671a13)? Andreas Müller
2011-10-27 20:43 ` Scott Garman
2011-10-27 21:42 ` Andreas Müller
2011-10-27 22:30 ` Scott Garman
2011-10-28 7:30 ` Henning Heinold
2011-10-28 10:22 ` Richard Purdie
2011-10-28 22:33 ` Andreas Müller
2011-11-09 20:38 ` Andreas Müller
2011-11-09 20:39 ` Martin Jansa
2011-11-09 20:56 ` Andreas Müller
2011-10-28 20:58 ` Klaus 'mrmoku' Kurzmann
2011-10-29 10:53 ` [PATCH] dbus: add work around to set right owner in postinst Martin Jansa
2011-10-30 4:13 ` Otavio Salvador
2011-10-30 4:17 ` Otavio Salvador
2011-10-31 8:54 ` Koen Kooi
2011-10-31 16:49 ` Saul Wold
2011-10-31 17:43 ` [PATCHv2] dbus: fix for " Martin Jansa
2011-10-31 22:40 ` Richard Purdie
2011-11-01 11:26 ` Koen Kooi
2011-11-01 14:16 ` Richard Purdie
2011-11-01 13:36 ` Martin Jansa
2011-11-01 14:15 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320156937.15387.6.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.