Re: [PATCH v2] mac80211: disassociate when direct probe timed out

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2011-11-07 at 16:34 +0100, Stanislaw Gruszka wrote:

> +++ b/net/mac80211/mlme.c
> @@ -2379,8 +2379,14 @@ ieee80211_probe_auth_done(struct ieee80211_work *wk,
>  			  struct sk_buff *skb)
>  {
>  	struct ieee80211_local *local = wk->sdata->local;
> +	struct ieee80211_if_managed *ifmgd = &wk->sdata->u.mgd;
>  
>  	if (!skb) {
> +		mutex_lock(&ifmgd->mtx);
> +		if (ifmgd->associated)
> +			ieee80211_set_disassoc(wk->sdata, true, false);
> +		mutex_unlock(&ifmgd->mtx);
> +
>  		cfg80211_send_auth_timeout(wk->sdata->dev, wk->filter_ta);
>  		goto destroy;
>  	}

This doesn't seem right -- we can authenticate with a new AP while
connected to an old one, but if the connection to the new one fails why
should we tear down the connection to the *old* one?

johannes