From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 7/7] pango: Fix bug 1674
Date: Tue, 08 Nov 2011 11:56:12 +0000 [thread overview]
Message-ID: <1320753373.22985.702.camel@phil-desktop> (raw)
In-Reply-To: <7fe88fd604911f096a522deafaaeda3a93f5f966.1320750179.git.xiaofeng.yan@windriver.com>
On Tue, 2011-11-08 at 19:16 +0800, Xiaofeng Yan wrote:
> - ${@base_contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"
> + ${@base_contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'directfb', '--with-x=no', '--with-x=yes', d)}"
That last line looks fairly wrong. If I am understanding this right
then someone with neither x11 nor directfb set would get "--without-x
--with-x=yes", and someone with directfb but not X would get
"--without-x --with-x=no" which surely can't be what's wanted. Did you
test this patchset?
>+ [ ! -d "/etc/pango" ] && mkdir -p /etc/pango/
Why can't you just ship this folder in the package rather than creating
it in the postinst? Also, this should probably be ${sysconfdir} rather
than hardcoded.
p.
next prev parent reply other threads:[~2011-11-08 12:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 11:15 [PATCH 0/7] gtk+ over directfb: Fix bug 1674 Xiaofeng Yan
2011-11-08 11:15 ` [PATCH 1/7] qemu-config.bb: " Xiaofeng Yan
2011-11-08 11:15 ` [PATCH 2/7] gtk+: " Xiaofeng Yan
2011-11-08 11:45 ` Koen Kooi
2011-11-08 13:18 ` Richard Purdie
2011-11-08 13:32 ` Koen Kooi
2011-11-08 13:51 ` Richard Purdie
2011-11-08 11:15 ` [PATCH 3/7] cairo: " Xiaofeng Yan
2011-11-08 11:52 ` Phil Blundell
2011-11-08 11:15 ` [PATCH 4/7] directfb-examples: " Xiaofeng Yan
2011-11-08 11:15 ` [PATCH 5/7] core-image-gtk-directfb-sdk: " Xiaofeng Yan
2011-11-08 11:15 ` [PATCH 6/7] core-image-gtk-directfb: " Xiaofeng Yan
2011-11-08 11:16 ` [PATCH 7/7] pango: " Xiaofeng Yan
2011-11-08 11:56 ` Phil Blundell [this message]
2011-11-08 11:46 ` [PATCH 0/7] gtk+ over directfb: " Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320753373.22985.702.camel@phil-desktop \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.