From: Lin Ming <ming.m.lin@intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-pm@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
Jeff Garzik <jgarzik@pobox.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
James Bottomley <JBottomley@parallels.com>,
Tejun Heo <tj@kernel.org>, Huang Ying <ying.huang@intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v2 1/4] ata: make ata port as parent device of scsi host
Date: Thu, 10 Nov 2011 14:22:43 +0800 [thread overview]
Message-ID: <1320906166-15459-2-git-send-email-ming.m.lin@intel.com> (raw)
In-Reply-To: <1320906166-15459-1-git-send-email-ming.m.lin@intel.com>
Currently, the device tree of ata port and scsi host looks as below,
/sys/devices/pci0000:00/0000:00:1f.2 (ahci controller)
|-- ata1 (ata port)
|-- host0 (scsi host)
|-- target0:0:0 (scsi target)
|-- 0:0:0:0 (disk)
This patch makes ata port as parent device of scsi host, then it becomes
/sys/devices/pci0000:00/0000:00:1f.2 (ahci controller)
|-- ata1 (ata port)
|-- host0 (scsi host)
|-- target0:0:0 (scsi target)
|-- 0:0:0:0 (disk)
With this change, the ata port runtime PM is easier.
For example, the ata port runtime suspend will happen as,
disk suspend --> scsi target suspend --> scsi host suspend --> ata port
suspend.
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
drivers/ata/libata-scsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 72a9770..4c2a524 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3394,7 +3394,7 @@ int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht)
*/
shost->max_host_blocked = 1;
- rc = scsi_add_host(ap->scsi_host, ap->host->dev);
+ rc = scsi_add_host(ap->scsi_host, &ap->tdev);
if (rc)
goto err_add;
}
--
1.7.2.5
next prev parent reply other threads:[~2011-11-10 6:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 6:22 [PATCH v2 0/4] ata port runtime power management support Lin Ming
2011-11-10 6:22 ` Lin Ming [this message]
2011-11-10 6:22 ` [PATCH v2 2/4] scsi: add flag to skip the runtime PM calls on host in EH Lin Ming
2011-11-10 6:22 ` [PATCH v2 3/4] ata: add ata port system PM callbacks Lin Ming
2011-11-10 6:22 ` [PATCH v2 4/4] ata: add ata port runtime " Lin Ming
2011-11-10 15:40 ` Alan Stern
2011-11-10 15:40 ` Alan Stern
2011-11-10 15:45 ` Tejun Heo
[not found] ` <CAF1ivSZ3rnb90u6LHXfWCBW-6mtfmWYjj1xXfABmm=uNVbomRw@mail.gmail.com>
2011-11-14 5:14 ` Lin Ming
2011-11-14 15:31 ` Alan Stern
2011-11-14 15:31 ` Alan Stern
2011-11-15 8:51 ` Lin Ming
2011-11-15 14:54 ` Tejun Heo
2011-11-15 16:08 ` Alan Stern
2011-11-16 13:14 ` Lin Ming
2011-11-16 15:42 ` Alan Stern
2011-11-10 15:30 ` [PATCH v2 0/4] ata port runtime power management support Tejun Heo
2011-11-10 15:31 ` Tejun Heo
2011-11-11 2:25 ` Lin Ming
2011-11-10 16:02 ` Kay Sievers
2011-11-11 2:33 ` Lin Ming
2011-11-10 15:30 ` Alan Stern
2011-11-10 15:30 ` Alan Stern
2011-11-10 15:37 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320906166-15459-2-git-send-email-ming.m.lin@intel.com \
--to=ming.m.lin@intel.com \
--cc=JBottomley@parallels.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.