From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Robert Richter <robert.richter@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
oprofile-list <oprofile-list@lists.sourceforge.net>
Subject: Re: [V2][PATCH 5/5] oprofile, x86: Reimplement nmi timer mode using perf event
Date: Thu, 10 Nov 2011 13:52:05 +0100 [thread overview]
Message-ID: <1320929525.13800.13.camel@twins> (raw)
In-Reply-To: <20111023112728.GB5156@elte.hu>
On Sun, 2011-10-23 at 13:27 +0200, Ingo Molnar wrote:
> * Robert Richter <robert.richter@amd.com> wrote:
>
> > The legacy x86 nmi watchdog code was removed with the implementation
> > of the perf based nmi watchdog. This broke Oprofile's nmi timer
> > mode. To run nmi timer mode we relied on a continuous ticking nmi
> > source which the nmi watchdog provided. The nmi tick was no longer
> > available and current watchdog can not be used anymore since it runs
> > with very long periods in the range of seconds. This patch
> > reimplements the nmi timer mode using a perf counter nmi source.
> >
> Looks clean to me. Peter, any objections?
No.
prev parent reply other threads:[~2011-11-10 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 18:47 [V2][PATCH 0/5] oprofile: Updates and fixes for timer modes Robert Richter
2011-10-19 18:47 ` [V2][PATCH 1/5] oprofile, x86: Add kernel parameter oprofile.cpu_type=timer Robert Richter
2011-10-19 18:47 ` [V2][PATCH 2/5] oprofile: Fix crash when unloading module (hr timer mode) Robert Richter
2011-10-19 18:47 ` [V2][PATCH 3/5] oprofile, x86: Fix crash when unloading module (nmi " Robert Richter
2011-10-19 18:47 ` [V2][PATCH 4/5] oprofile: Remove exit function for timer mode Robert Richter
2011-10-19 18:47 ` [V2][PATCH 5/5] oprofile, x86: Reimplement nmi timer mode using perf event Robert Richter
2011-10-23 11:27 ` Ingo Molnar
2011-11-01 17:54 ` Robert Richter
2011-11-10 12:52 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320929525.13800.13.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.