All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Tao <bergwolf@gmail.com>
To: linux-nfs@vger.kernel.org
Cc: Trond.Myklebust@netapp.com, bhalevy@tonian.com,
	Peng Tao <peng_tao@emc.com>
Subject: [PATCH-v2 6/7] pnfsblock: clean up _add_entry
Date: Thu, 10 Nov 2011 07:25:27 -0800	[thread overview]
Message-ID: <1320938728-3715-7-git-send-email-bergwolf@gmail.com> (raw)
In-Reply-To: <1320938728-3715-1-git-send-email-bergwolf@gmail.com>

It is wrong to kmalloc in _add_entry() as it is inside
spinlock. memory should be already allocated _add_entry() is called.

Signed-off-by: Peng Tao <peng_tao@emc.com>
---
 fs/nfs/blocklayout/extents.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c
index f383524..d0f52ed 100644
--- a/fs/nfs/blocklayout/extents.c
+++ b/fs/nfs/blocklayout/extents.c
@@ -110,13 +110,7 @@ static int _add_entry(struct my_tree *tree, u64 s, int32_t tag,
 		return 0;
 	} else {
 		struct pnfs_inval_tracking *new;
-		if (storage)
-			new = storage;
-		else {
-			new = kmalloc(sizeof(*new), GFP_NOFS);
-			if (!new)
-				return -ENOMEM;
-		}
+		new = storage;
 		new->it_sector = s;
 		new->it_tags = (1 << tag);
 		list_add(&new->it_link, &pos->it_link);
-- 
1.7.1.262.g5ef3d


  parent reply	other threads:[~2011-11-10 15:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 15:25 [PATCH-v2 0/7] pnfsblock cleanup and fixes Peng Tao
2011-11-10 15:25 ` [PATCH-v2 1/7] pnfsblock: cleanup bl_mark_sectors_init Peng Tao
2011-11-10 15:25 ` [PATCH-v2 3/7] pnfsblock: move find lock page logic out of bl_write_pagelist Peng Tao
2011-11-10 15:25 ` [PATCH-v2 4/7] pnfsblock: set read/write tk_status to pnfs_error Peng Tao
2011-11-10 15:25 ` [PATCH-v2 5/7] pnfsblock: remove rpc_call_ops from struct parallel_io Peng Tao
2011-11-10 15:25 ` Peng Tao [this message]
2011-11-10 15:25 ` [PATCH-v2 7/7] pnfsblock: alloc short extent before submit bio Peng Tao
2011-11-10 16:43   ` Bryan Schumaker
2011-11-11  2:05     ` tao.peng
2011-11-14 10:26       ` Benny Halevy
2011-11-14 14:18         ` Peng Tao
2011-11-10 15:37 ` [PATCH-v2 0/7] pnfsblock cleanup and fixes Peng Tao
2011-11-10 15:52 ` Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320938728-3715-7-git-send-email-bergwolf@gmail.com \
    --to=bergwolf@gmail.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bhalevy@tonian.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=peng_tao@emc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.