All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath: rlookup WWIDs with spaces by alias
Date: Sat, 12 Nov 2011 11:18:15 +0100	[thread overview]
Message-ID: <1321093095.14506.8.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <20111112045426.GD24133@ether.msp.redhat.com>

On ven., 2011-11-11 at 22:54 -0600, Benjamin Marzinski wrote:
> If a WWID contained spaces, the rlookup code wasn't able to look it up
> by its user_friendly_name, since the code was only reading the wwid till
> the first space.  It now reads to the end of the line.
> 
Applied

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  libmultipath/alias.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: multipath-tools-110412/libmultipath/alias.c
> ===================================================================
> --- multipath-tools-110412.orig/libmultipath/alias.c
> +++ multipath-tools-110412/libmultipath/alias.c
> @@ -288,7 +288,7 @@ rlookup_binding(FILE *f, char **map_wwid
>  		curr_id = scan_devname(alias, NULL); /* TBD: Why this call? */
>  		if (curr_id >= id)
>  			id = curr_id + 1;
> -		wwid = strtok(NULL, " \t");
> +		wwid = strtok(NULL, "");
>  		if (!wwid){
>  			condlog(3,
>  				"Ignoring malformed line %u in bindings file",

  reply	other threads:[~2011-11-12 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-12  4:54 [PATCH] multipath: rlookup WWIDs with spaces by alias Benjamin Marzinski
2011-11-12 10:18 ` Christophe Varoqui [this message]
2011-11-14  9:17 ` Hannes Reinecke
2011-11-14 18:34   ` Benjamin Marzinski
2011-11-15 20:41     ` Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321093095.14506.8.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.