All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Paul Turner <pjt@google.com>
Cc: Mike Galbraith <efault@gmx.de>, john stultz <johnstul@us.ibm.com>,
	Salman Qazi <sqazi@google.com>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: avoid unnecessary overflow in sched_clock
Date: Wed, 16 Nov 2011 09:56:22 +0100	[thread overview]
Message-ID: <1321433782.1421.71.camel@twins> (raw)
In-Reply-To: <4EC36165.3090002@google.com>

On Tue, 2011-11-15 at 23:08 -0800, Paul Turner wrote:
> Probably a good idea -- This especially sucks rocks in the sched_clock_stable==1 
> case; resulting in it coming straight back out of sched_clock_cpu() and trashing 
> rq->clock. 

There's another problem there in that TSC will wrap too soon and things
will blow up in your face that way.



  reply	other threads:[~2011-11-16  8:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 21:59 [PATCH] sched: avoid unnecessary overflow in sched_clock Salman Qazi
2011-11-15 22:12 ` Salman Qazi
2011-11-15 23:02   ` john stultz
2011-11-16  0:07     ` Paul Turner
2011-11-16  6:41     ` Mike Galbraith
2011-11-16  7:08       ` Paul Turner
2011-11-16  8:56         ` Peter Zijlstra [this message]
2011-11-16 20:55           ` Salman Qazi
2011-11-18 23:45   ` [tip:sched/urgent] sched, x86: Avoid " tip-bot for Salman Qazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321433782.1421.71.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=efault@gmx.de \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pjt@google.com \
    --cc=sqazi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.