From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326Ab1KPOl7 (ORCPT ); Wed, 16 Nov 2011 09:41:59 -0500 Received: from casper.infradead.org ([85.118.1.10]:39671 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856Ab1KPOl6 convert rfc822-to-8bit (ORCPT ); Wed, 16 Nov 2011 09:41:58 -0500 Subject: Re: [PATCH] tracing: add trace console From: Peter Zijlstra To: Johannes Berg Cc: Steven Rostedt , LKML , Frederic Weisbecker , Ingo Molnar , Thomas Gleixner , Andrew Morton Date: Wed, 16 Nov 2011 15:41:33 +0100 In-Reply-To: <1321453846.4502.0.camel@jlt3.sipsolutions.net> References: <1321438728.4773.16.camel@jlt3.sipsolutions.net> <1321452954.4181.20.camel@frodo> <1321453537.27735.0.camel@twins> <1321453846.4502.0.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.0.3- Message-ID: <1321454493.27735.2.camel@twins> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-11-16 at 15:30 +0100, Johannes Berg wrote: > > > > +config TRACE_CONSOLE > > > > + tristate "Support for a tracing console" > > > > + help > > > > + Say M (or Y if you must, but this is not recommended) > > > > Why not? > > It'll always be registered and you have no way to turn it off then, so > you can't trace without getting every printk. I didn't want to add extra > API to toggle it, but building it in might be a bit odd that way. OK, so maybe expand that help text a little to avoid the obvious question ;-)