From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Gleb Natapov <gleb@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
Jason Baron <jbaron@redhat.com>, rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH RFC] remove jump_label optimization for perf sched events
Date: Thu, 17 Nov 2011 14:10:12 +0100 [thread overview]
Message-ID: <1321535413.27735.35.camel@twins> (raw)
In-Reply-To: <20111117130032.GC16853@redhat.com>
On Thu, 2011-11-17 at 15:00 +0200, Gleb Natapov wrote:
> > That said, I'd much rather throttle this particular jump label than
> > remove it altogether, some people really don't like all this scheduler
> > hot path crap.
> What about moving perf_event_task_sched() to sched_(in|out)_preempt_notifiers?
> preempt notifiers checking is already on the scheduler hot path, so no
> additional overhead for perf case.
Same problem really, some people complain about the overhead of preempt
notifiers, also not all kernels have those in.
Futhermore I loathe notifier lists because they obscure wtf is done.
next prev parent reply other threads:[~2011-11-17 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 12:30 [PATCH RFC] remove jump_label optimization for perf sched events Gleb Natapov
2011-11-17 12:49 ` Peter Zijlstra
2011-11-17 13:00 ` Gleb Natapov
2011-11-17 13:10 ` Peter Zijlstra [this message]
2011-11-17 13:24 ` Avi Kivity
2011-11-17 13:47 ` Peter Zijlstra
2011-11-17 14:12 ` Avi Kivity
2011-11-17 13:29 ` Borislav Petkov
2011-11-17 13:47 ` Gleb Natapov
2011-11-21 13:17 ` Gleb Natapov
2011-11-24 13:23 ` Peter Zijlstra
2011-11-24 13:45 ` Gleb Natapov
2011-11-24 14:18 ` Peter Zijlstra
2011-11-24 17:43 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321535413.27735.35.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=gleb@redhat.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.