From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/9] scsi-disk: guess geometry
Date: Fri, 18 Nov 2011 15:03:07 +0100 [thread overview]
Message-ID: <1321624993-19033-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1321624993-19033-1-git-send-email-kwolf@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Old operating systems rely on correct geometry to convert from CHS
addresses to LBA. Providing correct data is necessary for them to boot.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/scsi-disk.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index cc4f9ef..73de0f6 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -797,7 +797,7 @@ static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf,
break;
}
/* if a geometry hint is available, use it */
- bdrv_get_geometry_hint(bdrv, &cylinders, &heads, &secs);
+ bdrv_guess_geometry(bdrv, &cylinders, &heads, &secs);
p[2] = (cylinders >> 16) & 0xff;
p[3] = (cylinders >> 8) & 0xff;
p[4] = cylinders & 0xff;
@@ -831,7 +831,7 @@ static int mode_sense_page(SCSIDiskState *s, int page, uint8_t **p_outbuf,
p[2] = 5000 >> 8;
p[3] = 5000 & 0xff;
/* if a geometry hint is available, use it */
- bdrv_get_geometry_hint(bdrv, &cylinders, &heads, &secs);
+ bdrv_guess_geometry(bdrv, &cylinders, &heads, &secs);
p[4] = heads & 0xff;
p[5] = secs & 0xff;
p[6] = s->qdev.blocksize >> 8;
--
1.7.6.4
next prev parent reply other threads:[~2011-11-18 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 14:03 [Qemu-devel] [PULL 0/9] Block patches for 1.0 Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 1/9] Documentation: Add section about iSCSI LUNS to qemu-doc Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 2/9] scsi: fix fw path Kevin Wolf
2011-11-18 14:03 ` Kevin Wolf [this message]
2011-11-18 14:03 ` [Qemu-devel] [PATCH 4/9] atapi: kill MODE SENSE(6), fix MODE SENSE(10) Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 5/9] scsi: update list of commands Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 6/9] scsi: fix parsing of allocation length field Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 7/9] scsi: remove block descriptors from CDs Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 8/9] scsi: pass down REQUEST SENSE to the device when there is no stored sense Kevin Wolf
2011-11-18 14:03 ` [Qemu-devel] [PATCH 9/9] scsi-block: always use SG_IO for MMC devices Kevin Wolf
2011-11-22 0:20 ` [Qemu-devel] [PULL 0/9] Block patches for 1.0 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321624993-19033-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.