From: Alexander Sverdlin <subaparts@yandex.ru>
To: Axel Lin <axel.lin@gmail.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls
Date: Sat, 19 Nov 2011 08:59:15 +0100 [thread overview]
Message-ID: <1321689555.5405.2.camel@r60e> (raw)
In-Reply-To: <1321684867.4103.2.camel@phoenix>
Hello!
According to changes in API, fix is correct.
Acked-by: Alexander Sverdlin <subaparts@yandex.ru>
On Sat, 2011-11-19 at 14:41 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/cs4271.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
> index 23d1bd5..69fde15 100644
> --- a/sound/soc/codecs/cs4271.c
> +++ b/sound/soc/codecs/cs4271.c
> @@ -434,7 +434,8 @@ static int cs4271_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg)
> {
> int ret;
> /* Set power-down bit */
> - ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, CS4271_MODE2_PDN);
> + ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN,
> + CS4271_MODE2_PDN);
> if (ret < 0)
> return ret;
> return 0;
> @@ -501,8 +502,9 @@ static int cs4271_probe(struct snd_soc_codec *codec)
> return ret;
> }
>
> - ret = snd_soc_update_bits(codec, CS4271_MODE2, 0,
> - CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
> + ret = snd_soc_update_bits(codec, CS4271_MODE2,
> + CS4271_MODE2_PDN | CS4271_MODE2_CPEN,
> + CS4271_MODE2_PDN | CS4271_MODE2_CPEN);
> if (ret < 0)
> return ret;
> ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0);
next prev parent reply other threads:[~2011-11-19 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 6:41 [PATCH] ASoC: cs4271: Fix wrong mask parameter in some snd_soc_update_bits calls Axel Lin
2011-11-19 7:59 ` Alexander Sverdlin [this message]
2011-11-20 20:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321689555.5405.2.camel@r60e \
--to=subaparts@yandex.ru \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=hsweeten@visionengravers.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.