Re: [PATCH v6 1/4] mldev: add headers for internal ML functions

[Thomas Monjalon <thomas@monjalon.net>]

07/02/2023 17:00, Srikanth Yalavarthi:
> Added header files for internal ML utility routines to convert
> IO type and format to string, IO type to size and routines to
> convert data types.
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
> Depends-on: series-26858 ("Implementation of mldev test application")

I'm not sure it depends really on the test application.

>  doc/guides/rel_notes/release_23_03.rst |   5 +
>  lib/mldev/meson.build                  |   2 +
>  lib/mldev/mldev_utils.c                |   5 +
>  lib/mldev/mldev_utils.h                | 345 +++++++++++++++++++++++++

Instead of just adding the header file,
it would have more sense to add the scalar implementation at the same time,
and split IO type and conversion in different patches.

> --- a/doc/guides/rel_notes/release_23_03.rst
> +++ b/doc/guides/rel_notes/release_23_03.rst
> +* **Added common driver functions for machine learning device library.**
> +
> +  * Added functions to translate IO type and format to string.
> +  * Added functions to quantize and dequantize inference IO data.

I don't think it does not deserve to be in the release notes.