Re: [PATCH 0/2] small mtd-utils fixes

[Artem Bityutskiy <dedekind1@gmail.com>]

On Sun, 2011-11-20 at 11:55 +0000, David Woodhouse wrote:
> On Sun, 2011-11-20 at 01:04 +0200, Artem Bityutskiy wrote:
> > # Prepare the tarball
> > git archive --format=tar --prefix="mtd-utils-$new_ver/" "v$new_ver" | \
> >         bzip2 > "mtd-utils-$new_ver.tar.bz2"
> 
> gpg --detach-sign -a "mtd-utils-$new_ver.tar.bz2"
> 
> > # Upload the tarball
> > scp "mtd-utils-$new_ver.tar.bz2" casper.infradead.org:/var/ftp/pub/mtd-utils/
> 
> mtd-utils-$new_ver.tar.bz2{.asc,}

OK, I've updated the script:

1. Added some sanity checks
2. Sign tags
3. Sign the tarball
4. Instead of uploading, print the instructions how to do this

#!/bin/sh -uef

# A small helper script to release mtd-utils. Takes the new version
# as a parameter.

fatal() {
	printf "Error: %s\n" "$1" >&2
	exit 1
}

usage() {
	cat <<EOF
Usage: ${0##*/} <new_ver> <outdir>

<new_ver>  - mtd utils version to create in X.Y.Z format
<outdir>   - the output directory where to store the tarball with the
             gpg signature
EOF
	exit 0
}

[ $# -eq 0 ] && usage
[ $# -eq 2 ] || fatal "Insufficient or too many argumetns"

new_ver="$1"; shift
outdir="$1"; shift

release_name="mtd-utils-$new_ver"
tag_name="v$new_ver"

# Make sure the input is sane and the makefile contains sensible version
echo "$new_ver" | egrep -q -x '[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+' ||
	fatal "please, provide new version in X.Y.Z format"

egrep -q -x 'VERSION = [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+' Makefile ||
	fatal "Makefile does not contain \"Version = X.Y.Z\" line"

# Make sure the git index is up-to-date
[ -z "$(git status --porcelain)" ] || fatal "Git index is not up-to-date"

# Make sure the tag does not exist
[ -z "$(git tag -l "$tag_name")" ] || fatal "Tag $tag_name already exists"

# Change the version in the Makefile
tmpfile="$(mktemp)"
sed -e "s/^VERSION = [[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+/VERSION = $new_ver/" \
	Makefile > "$tmpfile"
mv "$tmpfile" Makefile

# And commit the change
git commit -s -m "Release $release_name" Makefile

# Create new signed tag
git tag -m "$release_name" -s "$tag_name"

# Prepare signed tarball
git archive --format=tar --prefix="$release_name/" "$tag_name" | \
	bzip2 > "$outdir/$release_name.tar.bz2"
gpg --detach-sign -a "$outdir/$release_name.tar.bz2" > "$outdir/$release_name.tar.bz2.asc"

echo "Created $outdir/$release_name.tar.bz2"
echo "Please, verify, then push the tag and upload the tarball and the signature"
echo "You can use these commands:"
echo "git push $tag_name"
echo "scp $outdir/$release_name.tar.bz2 $outdir/$release_name.tar.bz2.asc casper.infradead.org:/var/ftp/pub/mtd-utils"