Re: [PATCH 1/3] rcu-more-fallout.patch

[Steven Rostedt <rostedt@goodmis.org>]

On Sat, 2011-11-19 at 13:50 +0100, John Kacur wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cherry-picked for v3.0-rt and fixed minor merge conflict
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  kernel/rcutiny.c |    2 ++

Is this really needed?

>From init/Kconfig:

config TINY_RCU
	bool "UP-only small-memory-footprint RCU"
	depends on !SMP && !PREEMPT_RT_FULL


This code isn't even compiled when PREEMPT_RT_FULL is set.

-- Steve

>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/rcutiny.c b/kernel/rcutiny.c
> index 7bbac7d..f1e4bee 100644
> --- a/kernel/rcutiny.c
> +++ b/kernel/rcutiny.c
> @@ -271,6 +271,7 @@ void call_rcu_sched(struct rcu_head *head, void (*func)(struct rcu_head *rcu))
>  }
>  EXPORT_SYMBOL_GPL(call_rcu_sched);
>  
> +#ifndef CONFIG_PREEMPT_RT_FULL
>  /*
>   * Post an RCU bottom-half callback to be invoked after any subsequent
>   * quiescent state.
> @@ -280,6 +281,7 @@ void call_rcu_bh(struct rcu_head *head, void (*func)(struct rcu_head *rcu))
>  	__call_rcu(head, func, &rcu_bh_ctrlblk);
>  }
>  EXPORT_SYMBOL_GPL(call_rcu_bh);
> +#endif
>  
>  void rcu_barrier_bh(void)
>  {