From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/5] matchbox-stroke: Fix linking error with gold
Date: Wed, 23 Nov 2011 12:31:04 +0000 [thread overview]
Message-ID: <1322051464.18926.76.camel@ted> (raw)
In-Reply-To: <CAMKF1sqAuNv+r838gHTi8b0omTQBa7VkjahGAiEzBg137hyhHw@mail.gmail.com>
On Tue, 2011-11-22 at 19:00 -0800, Khem Raj wrote:
> On Tue, Nov 22, 2011 at 8:28 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Sun, 2011-11-20 at 09:50 -0800, Khem Raj wrote:
> >> Gold defaults to no-add-needed thetefore
> >> it does not link with librtaries that are not on cmdline
> >> it needs libXrender but is not on the linker cmdline
> >> so add it.
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> .../matchbox-stroke/files/ldadd_libXrender.patch | 25 ++++++++++++++++++++
> >> .../matchbox-stroke/matchbox-stroke_git.bb | 6 +++-
> >> 2 files changed, 29 insertions(+), 2 deletions(-)
> >> create mode 100644 meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch
> >>
> >> diff --git a/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch b/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch
> >> new file mode 100644
> >> index 0000000..90d2057
> >> --- /dev/null
> >> +++ b/meta/recipes-sato/matchbox-stroke/files/ldadd_libXrender.patch
> >> @@ -0,0 +1,25 @@
> >> +with GNU binutils-gold the
> >> +important difference is that --no-add-needed is the default behavior of GNU
> >> +binutils-gold. Please provide all needed libraries to the linker when building
> >> +your executables.
> >> +
> >> +Otherwise we get link errors like
> >> +
> >> +/home/kraj/work/angstrom/build/tmp-angstrom_2010_x-eglibc/sysroots/x86_64-linux/usr/libexec/armv5te-angstrom-linux-gnueabi/gcc/arm-angstrom-linux-gnueabi/4.6.2/ld: matchbox-stroke-ui.o: in function mb_stroke_ui_resources_create:matchbox-stroke-ui.c:223: error: undefined reference to 'XRenderCreatePicture'collect2: ld returned 1 exit statusmake[2]: *** [matchbox-stroke] Error 1
> >> +
> >> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> +
> >> +Upstream-Status: Pending
> >> +Index: git/src/Makefile.am
> >> +===================================================================
> >> +--- git.orig/src/Makefile.am 2011-10-22 19:25:52.000000000 -0700
> >> ++++ git/src/Makefile.am 2011-10-22 19:27:07.746428946 -0700
> >> +@@ -6,7 +6,7 @@
> >> +
> >> + bin_PROGRAMS = matchbox-stroke
> >> +
> >> +-matchbox_stroke_LDADD = $(MBSTROKE_LIBS) $(EXPAT_LIBS) -lm
> >> ++matchbox_stroke_LDADD = $(MBSTROKE_LIBS) $(EXPAT_LIBS) -lm -lXrender
> >> +
> >
> > I had a look at this and -lXrender is listed in MBSTROKE_LIBS. I'm
> > therefore a little puzzled on why this patch is needed? I appreciate the
> > commandline is order sensitive but that order should work?
>
> In my case
>
> Makefile:MBSTROKE_LIBS = -lXft -lX11 -lXtst -lfakekey
I can now see why I'm confused:
http://git.yoctoproject.org/cgit.cgi/matchbox-stroke/commit/?id=2b772583b61d2f6e8358e7c80e10293fc27cfcb7
We need to update the SRCREV. I'll push something to take care of this.
Cheers,
Richard
next prev parent reply other threads:[~2011-11-23 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 17:50 [PATCH 0/5] Fixes for uclibc based builds Khem Raj
2011-11-20 17:50 ` [PATCH 1/5] matchbox-stroke: Fix linking error with gold Khem Raj
2011-11-22 16:28 ` Richard Purdie
2011-11-23 3:00 ` Khem Raj
2011-11-23 12:31 ` Richard Purdie [this message]
2011-11-20 17:50 ` [PATCH 2/5] gettext_0.18.1.1: Fix QA Issue Khem Raj
2011-11-20 17:50 ` [PATCH 3/5] pulseaudio-0.9.23: Fix build on uclibc Khem Raj
2011-11-20 21:20 ` Paul Menzel
2011-11-20 17:50 ` [PATCH 4/5] netbase: Update recipe 4.46 -> 4.47 Khem Raj
2011-11-21 17:53 ` Koen Kooi
2011-11-21 18:59 ` Richard Purdie
2011-11-20 17:50 ` [PATCH 5/5] gcc-4.6: Fix gcc ICE on qt4-x11-free/armv7-a Khem Raj
2011-11-24 11:10 ` [PATCH 0/5] Fixes for uclibc based builds Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322051464.18926.76.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.