From: Alexander Sverdlin <subaparts@yandex.ru>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: Axel Lin <axel.lin@gmail.com>, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Ryan Mallon <rmallon@gmail.com>
Subject: Re: [PATCH] ASoC: Convert ep93xx directory to module_platform_driver
Date: Thu, 24 Nov 2011 07:46:23 +0100 [thread overview]
Message-ID: <1322117183.485.0.camel@r60e> (raw)
In-Reply-To: <20111124053230.GA2621@mwesterb-mobl.ger.corp.intel.com>
On Thu, 2011-11-24 at 07:32 +0200, Mika Westerberg wrote:
> On Thu, Nov 24, 2011 at 12:07:55PM +0800, Axel Lin wrote:
> > Factor out some boilerplate code.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
Acked-by: Alexander Sverdlin <subaparts@yandex.ru>
>
> > ---
> > sound/soc/ep93xx/edb93xx.c | 12 +-----------
> > sound/soc/ep93xx/ep93xx-ac97.c | 12 +-----------
> > sound/soc/ep93xx/ep93xx-i2s.c | 13 +------------
> > sound/soc/ep93xx/ep93xx-pcm.c | 13 +------------
> > sound/soc/ep93xx/simone.c | 12 +-----------
> > sound/soc/ep93xx/snappercl15.c | 13 +------------
> > 6 files changed, 6 insertions(+), 69 deletions(-)
> >
> > diff --git a/sound/soc/ep93xx/edb93xx.c b/sound/soc/ep93xx/edb93xx.c
> > index 51930b6..6b90c75 100644
> > --- a/sound/soc/ep93xx/edb93xx.c
> > +++ b/sound/soc/ep93xx/edb93xx.c
> > @@ -131,17 +131,7 @@ static struct platform_driver edb93xx_driver = {
> > .remove = __devexit_p(edb93xx_remove),
> > };
> >
> > -static int __init edb93xx_init(void)
> > -{
> > - return platform_driver_register(&edb93xx_driver);
> > -}
> > -module_init(edb93xx_init);
> > -
> > -static void __exit edb93xx_exit(void)
> > -{
> > - platform_driver_unregister(&edb93xx_driver);
> > -}
> > -module_exit(edb93xx_exit);
> > +module_platform_driver(edb93xx_driver);
> >
> > MODULE_AUTHOR("Alexander Sverdlin <subaparts@yandex.ru>");
> > MODULE_DESCRIPTION("ALSA SoC EDB93xx");
> > diff --git a/sound/soc/ep93xx/ep93xx-ac97.c b/sound/soc/ep93xx/ep93xx-ac97.c
> > index 3cd6158..ca0b07a 100644
> > --- a/sound/soc/ep93xx/ep93xx-ac97.c
> > +++ b/sound/soc/ep93xx/ep93xx-ac97.c
> > @@ -449,17 +449,7 @@ static struct platform_driver ep93xx_ac97_driver = {
> > },
> > };
> >
> > -static int __init ep93xx_ac97_init(void)
> > -{
> > - return platform_driver_register(&ep93xx_ac97_driver);
> > -}
> > -module_init(ep93xx_ac97_init);
> > -
> > -static void __exit ep93xx_ac97_exit(void)
> > -{
> > - platform_driver_unregister(&ep93xx_ac97_driver);
> > -}
> > -module_exit(ep93xx_ac97_exit);
> > +module_platform_driver(ep93xx_ac97_driver);
> >
> > MODULE_DESCRIPTION("EP93xx AC97 ASoC Driver");
> > MODULE_AUTHOR("Mika Westerberg <mika.westerberg@iki.fi>");
> > diff --git a/sound/soc/ep93xx/ep93xx-i2s.c b/sound/soc/ep93xx/ep93xx-i2s.c
> > index 099614e..274234b 100644
> > --- a/sound/soc/ep93xx/ep93xx-i2s.c
> > +++ b/sound/soc/ep93xx/ep93xx-i2s.c
> > @@ -464,18 +464,7 @@ static struct platform_driver ep93xx_i2s_driver = {
> > },
> > };
> >
> > -static int __init ep93xx_i2s_init(void)
> > -{
> > - return platform_driver_register(&ep93xx_i2s_driver);
> > -}
> > -
> > -static void __exit ep93xx_i2s_exit(void)
> > -{
> > - platform_driver_unregister(&ep93xx_i2s_driver);
> > -}
> > -
> > -module_init(ep93xx_i2s_init);
> > -module_exit(ep93xx_i2s_exit);
> > +module_platform_driver(ep93xx_i2s_driver);
> >
> > MODULE_ALIAS("platform:ep93xx-i2s");
> > MODULE_AUTHOR("Ryan Mallon");
> > diff --git a/sound/soc/ep93xx/ep93xx-pcm.c b/sound/soc/ep93xx/ep93xx-pcm.c
> > index 23de792..93ec013 100644
> > --- a/sound/soc/ep93xx/ep93xx-pcm.c
> > +++ b/sound/soc/ep93xx/ep93xx-pcm.c
> > @@ -339,18 +339,7 @@ static struct platform_driver ep93xx_pcm_driver = {
> > .remove = __devexit_p(ep93xx_soc_platform_remove),
> > };
> >
> > -static int __init ep93xx_soc_platform_init(void)
> > -{
> > - return platform_driver_register(&ep93xx_pcm_driver);
> > -}
> > -
> > -static void __exit ep93xx_soc_platform_exit(void)
> > -{
> > - platform_driver_unregister(&ep93xx_pcm_driver);
> > -}
> > -
> > -module_init(ep93xx_soc_platform_init);
> > -module_exit(ep93xx_soc_platform_exit);
> > +module_platform_driver(ep93xx_pcm_driver);
> >
> > MODULE_AUTHOR("Ryan Mallon");
> > MODULE_DESCRIPTION("EP93xx ALSA PCM interface");
> > diff --git a/sound/soc/ep93xx/simone.c b/sound/soc/ep93xx/simone.c
> > index 968cb31..1e00b33 100644
> > --- a/sound/soc/ep93xx/simone.c
> > +++ b/sound/soc/ep93xx/simone.c
> > @@ -81,17 +81,7 @@ static struct platform_driver simone_driver = {
> > .remove = __devexit_p(simone_remove),
> > };
> >
> > -static int __init simone_init(void)
> > -{
> > - return platform_driver_register(&simone_driver);
> > -}
> > -module_init(simone_init);
> > -
> > -static void __exit simone_exit(void)
> > -{
> > - platform_driver_unregister(&simone_driver);
> > -}
> > -module_exit(simone_exit);
> > +module_platform_driver(simone_driver);
> >
> > MODULE_DESCRIPTION("ALSA SoC Simplemachines Sim.One");
> > MODULE_AUTHOR("Mika Westerberg <mika.westerberg@iki.fi>");
> > diff --git a/sound/soc/ep93xx/snappercl15.c b/sound/soc/ep93xx/snappercl15.c
> > index 2cde433..33901d6 100644
> > --- a/sound/soc/ep93xx/snappercl15.c
> > +++ b/sound/soc/ep93xx/snappercl15.c
> > @@ -147,18 +147,7 @@ static struct platform_driver snappercl15_driver = {
> > .remove = __devexit_p(snappercl15_remove),
> > };
> >
> > -static int __init snappercl15_init(void)
> > -{
> > - return platform_driver_register(&snappercl15_driver);
> > -}
> > -
> > -static void __exit snappercl15_exit(void)
> > -{
> > - platform_driver_unregister(&snappercl15_driver);
> > -}
> > -
> > -module_init(snappercl15_init);
> > -module_exit(snappercl15_exit);
> > +module_platform_driver(snappercl15_driver);
> >
> > MODULE_AUTHOR("Ryan Mallon");
> > MODULE_DESCRIPTION("ALSA SoC Snapper CL15");
> > --
> > 1.7.5.4
> >
> >
>
prev parent reply other threads:[~2011-11-24 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 4:07 [PATCH] ASoC: Convert ep93xx directory to module_platform_driver Axel Lin
2011-11-24 5:32 ` Mika Westerberg
2011-11-24 6:46 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322117183.485.0.camel@r60e \
--to=subaparts@yandex.ru \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=mika.westerberg@iki.fi \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.