From: Sasha Levin <levinsasha928@gmail.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] iio: Fix build error in industrialio-core.c
Date: Thu, 24 Nov 2011 10:54:41 +0200 [thread overview]
Message-ID: <1322124881.4248.8.camel@lappy> (raw)
In-Reply-To: <4e3c37a6-3777-4138-800b-f055f7caa8f3@email.android.com>
On Thu, 2011-11-24 at 08:49 +0000, Jonathan Cameron wrote:
>
> Sasha Levin <levinsasha928@gmail.com> wrote:
>
> >The error was introduced in commit b4641336 ("iio: fix a leak due to
> >improper use of anon_inode_getfd()").
> >
> >Looks like the code wasn't even compile tested. Instead of just fixing
> >the
> >error I changed the function a bit to make it nicer.
> Minimal change would have been slightly nicer but clean up is obvious so fine. Thanks for doing this. Andrew m has a dirty build fix in NM but he will drop that when this hits.
If you'd like I can split it into two patches, the fix and the cleanup.
--
Sasha.
next prev parent reply other threads:[~2011-11-24 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 10:13 [PATCH] iio: Fix build error in industrialio-core.c Sasha Levin
2011-11-23 14:17 ` Dan Carpenter
2011-11-23 14:21 ` Sasha Levin
2011-11-24 8:49 ` Jonathan Cameron
2011-11-24 8:54 ` Sasha Levin [this message]
2011-11-24 9:11 ` Jonathan Cameron
2011-11-24 23:47 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322124881.4248.8.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.