From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id E99386B002D for ; Mon, 28 Nov 2011 14:52:23 -0500 (EST) Message-ID: <1322509921.2921.159.camel@twins> Subject: Re: [PATCH 3/5] uprobes: introduce uprobe_xol_slots[NR_CPUS] From: Peter Zijlstra Date: Mon, 28 Nov 2011 20:52:01 +0100 In-Reply-To: <1322509712.2921.158.camel@twins> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111128190614.GA4602@redhat.com> <20111128190714.GD4602@redhat.com> <1322509712.2921.158.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Oleg Nesterov Cc: Srikar Dronamraju , Linus Torvalds , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson On Mon, 2011-11-28 at 20:48 +0100, Peter Zijlstra wrote: > On Mon, 2011-11-28 at 20:07 +0100, Oleg Nesterov wrote: > > + UPROBE_XOL_FIRST_PAGE =3D UPROBE_XOL_LAST_PAGE > > + + NR_CPUS * UPROBES_XOL_SLOT_BYTES / PAGE= _SIZE,=20 >=20 > I think that wants to be:=20 > + DIV_ROUND_UP(NR_CPUS * UPROBES_XOL_SLOT_BYTES, PAGE_SIZE); >=20 > otherwise you'll end up with 0 pages for UP and the sort. Ah, no I see, you'll already have the one LAST_PAGE thing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754244Ab1K1Tw3 (ORCPT ); Mon, 28 Nov 2011 14:52:29 -0500 Received: from casper.infradead.org ([85.118.1.10]:59698 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752836Ab1K1Tw2 convert rfc822-to-8bit (ORCPT ); Mon, 28 Nov 2011 14:52:28 -0500 Message-ID: <1322509921.2921.159.camel@twins> Subject: Re: [PATCH 3/5] uprobes: introduce uprobe_xol_slots[NR_CPUS] From: Peter Zijlstra To: Oleg Nesterov Cc: Srikar Dronamraju , Linus Torvalds , Andrew Morton , LKML , Linux-mm , Ingo Molnar , Andi Kleen , Christoph Hellwig , Steven Rostedt , Roland McGrath , Thomas Gleixner , Masami Hiramatsu , Arnaldo Carvalho de Melo , Anton Arapov , Ananth N Mavinakayanahalli , Jim Keniston , Stephen Wilson Date: Mon, 28 Nov 2011 20:52:01 +0100 In-Reply-To: <1322509712.2921.158.camel@twins> References: <20111118110631.10512.73274.sendpatchset@srdronam.in.ibm.com> <20111128190614.GA4602@redhat.com> <20111128190714.GD4602@redhat.com> <1322509712.2921.158.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-11-28 at 20:48 +0100, Peter Zijlstra wrote: > On Mon, 2011-11-28 at 20:07 +0100, Oleg Nesterov wrote: > > + UPROBE_XOL_FIRST_PAGE = UPROBE_XOL_LAST_PAGE > > + + NR_CPUS * UPROBES_XOL_SLOT_BYTES / PAGE_SIZE, > > I think that wants to be: > + DIV_ROUND_UP(NR_CPUS * UPROBES_XOL_SLOT_BYTES, PAGE_SIZE); > > otherwise you'll end up with 0 pages for UP and the sort. Ah, no I see, you'll already have the one LAST_PAGE thing.