All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [oe-core 4/5] libsdl: enable alsa based on PACKAGECONFIG and respect DISTRO_FEATURES
Date: Tue, 29 Nov 2011 13:41:35 +0000	[thread overview]
Message-ID: <1322574095.6171.0.camel@ted> (raw)
In-Reply-To: <572ee988031418b5bc01716ac39b873aa7b915bd.1322570605.git.Martin.Jansa@gmail.com>

On Tue, 2011-11-29 at 13:48 +0100, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-graphics/libsdl/libsdl_1.2.14.bb |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> index 17a3103..e5fdcc3 100644
> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> @@ -29,7 +29,7 @@ SRC_URI[sha256sum] = "5d927e287034cb6bb0ebccfa382cb1d185cb113c8ab5115a0759798642
>  inherit autotools binconfig pkgconfig
>  
>  EXTRA_OECONF = "--disable-static --disable-debug --enable-cdrom --enable-threads --enable-timers --enable-endian \
> -                --enable-file --disable-oss --enable-alsa --disable-esd --disable-arts \
> +                --enable-file --disable-oss --disable-esd --disable-arts \
>                  --disable-diskaudio --disable-nas --disable-esd-shared --disable-esdtest \
>                  --disable-mintaudio --disable-nasm --enable-video-x11 --disable-video-dga \
>                  --disable-video-fbcon --disable-video-directfb --disable-video-ps2gs --disable-video-ps3 \
> @@ -40,6 +40,9 @@ EXTRA_OECONF = "--disable-static --disable-debug --enable-cdrom --enable-threads
>                  --disable-video-picogui --disable-video-qtopia --enable-dlopen \
>                  --disable-rpath"
>  
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d)}"
> +PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib,"
> +
>  PARALLEL_MAKE = ""

Doesn't this patch need to remove alsa-lib from DEPENDS?

I've taken the other four patches.

Cheers,

Richard




  reply	other threads:[~2011-11-29 13:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 12:47 [oe-core 0/5] libsdl changes v2 Martin Jansa
2011-11-29 12:48 ` [oe-core 1/5] libsdl: drop unused files Martin Jansa
2011-11-29 12:48 ` [oe-core 2/5] libsdl: rename files dir to libsdl-1.2.14 for faster lookup Martin Jansa
2011-11-29 12:48 ` [oe-core 3/5] libsdl: enable cdrom, alsa and tslib, disable rpath and add few fixes from meta-oe Martin Jansa
2011-11-29 12:48 ` [oe-core 4/5] libsdl: enable alsa based on PACKAGECONFIG and respect DISTRO_FEATURES Martin Jansa
2011-11-29 13:41   ` Richard Purdie [this message]
2011-11-29 12:48 ` [oe-core 5/5] libsdl: replace tabs with spaces Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322574095.6171.0.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.