From: Sasha Levin <levinsasha928@gmail.com>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Process virito blk requests in separate thread
Date: Tue, 29 Nov 2011 16:36:49 +0200 [thread overview]
Message-ID: <1322577409.7003.7.camel@lappy> (raw)
In-Reply-To: <1322576888-7451-1-git-send-email-asias.hejun@gmail.com>
On Tue, 2011-11-29 at 22:28 +0800, Asias He wrote:
> Currently, all blk requests are processed in notify_vq() which is in
> the context of ioeventfd thread: ioeventfd__thread(). The processing
> in notify_vq() may take a long time to complete.
>
> We should make notify_vq() return as soon as possible, since all devices
> are sharing the single ioeventfd thread. Otherwise, it will block other
> device's notify_vq() being called and starve other devices.
>
> In virtio net's notify_vq(), we simply signal the tx/rx handle thread
> and return.
Why not use the threadpool?
>
> This patch makes virtio blk's notify_vq() just notify the blk thread
> instead of doing the real hard read/write work. Tests show that the
> overhead of the notification operations introduced by this patch is
> small.
>
> Signed-off-by: Asias He <asias.hejun@gmail.com>
> ---
--
Sasha.
next prev parent reply other threads:[~2011-11-29 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 14:28 [PATCH] kvm tools: Process virito blk requests in separate thread Asias He
2011-11-29 14:36 ` Sasha Levin [this message]
2011-11-30 7:21 ` Asias He
2011-12-01 8:48 ` Pekka Enberg
2011-12-01 8:58 ` Sasha Levin
2011-12-01 10:45 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2012-06-04 15:40 Asias He
2012-06-04 15:48 ` Cyrill Gorcunov
2012-06-05 0:47 ` Asias He
2012-06-05 6:10 ` Cyrill Gorcunov
2012-06-04 16:07 ` Sasha Levin
2012-06-05 1:03 ` Asias He
2012-06-05 8:14 ` Pekka Enberg
2012-06-06 12:35 ` Paolo Bonzini
2012-06-07 1:38 ` Asias He
2012-06-07 8:47 ` Paolo Bonzini
2012-06-08 3:30 ` Asias He
2012-06-05 8:15 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322577409.7003.7.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.