From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Lameter <cl@linux.com>
Cc: David Rientjes <rientjes@google.com>,
Hans Schillstrom <hans@schillstrom.com>,
Ingo Molnar <mingo@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Matt Mackall <mpm@selenic.com>,
Sitsofe Wheeler <sitsofe@yahoo.com>,
linux-mm@kvack.org
Subject: Re: possible slab deadlock while doing ifenslave
Date: Tue, 29 Nov 2011 16:38:41 +0100 [thread overview]
Message-ID: <1322581121.2921.245.camel@twins> (raw)
In-Reply-To: <alpine.DEB.2.00.1111290855570.14101@router.home>
On Tue, 2011-11-29 at 08:58 -0600, Christoph Lameter wrote:
> On Mon, 28 Nov 2011, Peter Zijlstra wrote:
>
> > Currently we only annotate the kmalloc caches, annotate all of them.
>
> What is the benefit?
Extra paranoia I guess.. I was fairly sure it was pointless, but I send
it anyway.
> The metadata for off slab caches uses the
> kmalloc array. Should the annotation for the kmalloc cache not be
> sufficient by putting that into a different lock category? Non-kmalloc
> caches already have a different lock category before this patch right?
Yeah, we annotate all kmalloc caches that have l3 and aren't OFF_SLAB().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-29 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 8:19 possible slab deadlock while doing ifenslave Hans Schillstrom
2011-10-12 20:35 ` David Rientjes
2011-10-13 8:19 ` Hans Schillstrom
2011-10-13 23:03 ` David Rientjes
2011-10-13 23:21 ` Peter Zijlstra
2011-10-14 6:30 ` Hans Schillstrom
2011-11-28 21:19 ` Peter Zijlstra
2011-11-28 21:20 ` Peter Zijlstra
2011-11-29 14:58 ` Christoph Lameter
2011-11-29 15:38 ` Peter Zijlstra [this message]
2011-11-29 14:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322581121.2921.245.camel@twins \
--to=peterz@infradead.org \
--cc=cl@linux.com \
--cc=hans@schillstrom.com \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
--cc=sitsofe@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.