From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] iw: Support ht-capability overrides mask.
Date: Tue, 29 Nov 2011 18:56:43 +0100 [thread overview]
Message-ID: <1322589403.4110.27.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4ED51BF5.9010508@candelatech.com>
On Tue, 2011-11-29 at 09:52 -0800, Ben Greear wrote:
> On 11/29/2011 12:51 AM, Johannes Berg wrote:
> > On Mon, 2011-11-28 at 10:40 -0800, greearb@candelatech.com wrote:
> >> From: Ben Greear<greearb@candelatech.com>
> >>
> >> Let user know which capabilities are supported.
> >
> > I applied this with a bunch of modifications, but I think you should
> > follow up and make it more complete. You're covering exactly and only
> > the case that you're working on right now, I don't think that's good
> > practice.
>
> It looks to me like your change isn't going to compile on older
> systems (Fedora Core 8, for instance), because htole16 isn't
> defined there (no endian.h file).
>
> That is why I hand-coded an equivalent method...
I assume you mean Fedora 8 (they dropped the Core after 6)? That was
released, uh, about 4 years ago. I don't think I care.
johannes
prev parent reply other threads:[~2011-11-29 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 18:40 [PATCH v3] iw: Support ht-capability overrides mask greearb
2011-11-29 8:51 ` Johannes Berg
2011-11-29 17:12 ` Ben Greear
2011-11-29 17:52 ` Ben Greear
2011-11-29 17:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322589403.4110.27.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.