Re: [PATCH 2/4] nl80211: Parse channel type attribute in an ibss join request

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2011-11-30 at 13:27 +0100, Simon Wunderlich wrote:
> Hey Johannes,
> 
> On Wed, Nov 30, 2011 at 01:16:46PM +0100, Johannes Berg wrote:
> > On Mon, 2011-11-28 at 18:55 +0100, Simon Wunderlich wrote:
> > > Prepare cfg80211 for IBSS HT:
> > >  * extend cfg80211 ibss struct with channel_type
> > >  * Check if extension channel can be used
> > >  * Export can_beacon_sec_chan for use in mac80211 (will be called
> > >    from ibss.c later).
> > 
> > I'm thinking there should be a "driver supports HT IBSS" flag, and we
> > reject the config otherwise?
> 
> There is already an implicit check for this - rdev_freq_to_chan() checks
> if the channel_type is supported, and -EINVAL otherwise. So if I call 
> ibss_join with HT20 or HT40 on ath5k, it gets rejected already.

Right, but this just checks if HT is supported, not if HT-IBSS is
supported. I can see some cfg80211 drivers implementing HT and IBSS, but
not HT-IBSS, just like mac80211 before these patches.

> If this is not enough and we need a further flag, could you please give
> me a hint how/where to implement it?

I'd add it to enum nl80211_feature_flags.

johannes