All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFCv0 0/3] AMP HCI interface from A2MP
Date: Wed, 30 Nov 2011 15:31:24 +0100	[thread overview]
Message-ID: <1322663484.26198.16.camel@aeonflux> (raw)
In-Reply-To: <1322661272-32027-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

> The code adds AMP HCI commands from A2MP protocol. HCI events are handled
> similar way as mgmt interface. amp_pending is a kind of copy of mgmt_pending.

this is all kernel internal code with no interface to user space. I do
not see the need for such a complex infrastructure. Can not just have
proper callbacks or event callback table like with L2CAP. Or just
something similar.

As far as I see it, we get an A2MP command over L2CAP fixed channel, we
have to issue a HCI command or do some other task based on this and then
respond to it. We only have one user of this first of all. And second of
all, I think we can not really have pending A2MP commands anyway. This
is pretty much one command at a time (per ACL link).

If I am mistaken here, please correct here. It has been a while since I
read that specification.

Regards

Marcel



  parent reply	other threads:[~2011-11-30 14:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 13:54 [RFCv0 0/3] AMP HCI interface from A2MP Emeltchenko Andrei
2011-11-30 13:54 ` [RFCv0 1/3] Bluetooth: AMP: HCI infrastructure Emeltchenko Andrei
2011-11-30 13:54 ` [RFCv0 2/3] Bluetooth: AMP: Initialize and free amp_pending Emeltchenko Andrei
2011-11-30 13:54 ` [RFCv0 3/3] Bluetooth: AMP: Read Local AMP Info Emeltchenko Andrei
2011-11-30 14:31 ` Marcel Holtmann [this message]
2011-11-30 15:18   ` [RFCv0 0/3] AMP HCI interface from A2MP Emeltchenko Andrei
2011-12-01  6:19     ` Peter Krystad
2011-12-01 11:21       ` Marcel Holtmann
2011-12-02  6:39         ` Peter Krystad
2011-12-08 14:07           ` 'Emeltchenko Andrei'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322663484.26198.16.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.