All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] consolekit: package /var/log/Consolekit
Date: Wed, 30 Nov 2011 20:19:58 +0000	[thread overview]
Message-ID: <1322684398.17484.31.camel@ted> (raw)
In-Reply-To: <F82CA009-53D5-45C1-AD7B-E0168518436F@dominion.thruhere.net>

On Wed, 2011-11-30 at 18:50 +0100, Koen Kooi wrote:
> Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
> 
> > On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> >> This fixes startup issues like this:
> >> 
> >> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
> >> (process:91): WARNING **: Couldn't create log
> >> file /var/log/ConsoleKit/history (No such file or directory)
> >> 
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> .../recipes-support/consolekit/consolekit_0.4.5.bb |    4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> index 562dfb3..a02203c 100644
> >> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
> >> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
> >> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
> >> 
> >> -PR = "r5"
> >> +PR = "r6"
> >> 
> >> LICENSE = "GPLv2+"
> >> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> >> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> >>                 ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
> >>                "
> >> 
> >> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
> >> 
> >> PACKAGES =+ "pam-plugin-ck-connector"
> > 
> > Looks like this is breaking builds:
> > 
> > | consolekit                  ##################################################
> > | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
> > 
> > :(
> > 
> > http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
> 
> I suspect that's another victim of fs-perms.txt and rpm, it seems to
> break if /var/log is a symlink in other packages. I am going to argue
> that the breakage isn't a bug in consolekit :)

I really don't care whether its a bug in consolekit or not. The point is
that builds that were working before this change are now broken and we
have a regression.

Who is going to fix the regression?

Someone told me the answer is easy, I just revert the appropriate patch.
I tend to take on a lot of these types of issues and silently fix them
but I really need some help with it...

Cheers,

Richard





  reply	other threads:[~2011-11-30 20:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  8:24 [PATCH] consolekit: package /var/log/Consolekit Koen Kooi
2011-11-30 15:11 ` Richard Purdie
2011-11-30 17:38 ` Richard Purdie
2011-11-30 17:50   ` Koen Kooi
2011-11-30 20:19     ` Richard Purdie [this message]
2011-11-30 20:39       ` Koen Kooi
2011-11-30 22:57         ` Richard Purdie
2011-11-30 17:51   ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322684398.17484.31.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.