From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] qla2xxx: Don't memset buffer unless debug level is enabled Date: Thu, 1 Dec 2011 18:07:43 +0000 Message-ID: <1322762860.6920.47.camel@dabdike> References: <1322690639-20756-1-git-send-email-nab@linux-iscsi.org> <4ED736EB.4090201@linutronix.de> <1322731309.25753.30.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <75E3F0535278014E8437B6604491AE46@sw.swsoft.com> Sender: target-devel-owner@vger.kernel.org To: Chad Dupuis Cc: "Nicholas A. Bellinger" , Sebastian Andrzej Siewior , linux-scsi , target-devel , Andrew Vasquez , Giridhar Malavali , Roland Dreier , Joern Engel List-Id: linux-scsi@vger.kernel.org T24gVGh1LCAyMDExLTEyLTAxIGF0IDEzOjAxIC0wNTAwLCBDaGFkIER1cHVpcyB3cm90ZToNCj4g DQo+IE9uIFRodSwgMSBEZWMgMjAxMSwgTmljaG9sYXMgQS4gQmVsbGluZ2VyIHdyb3RlOg0KPiAN Cj4gPiBPbiBUaHUsIDIwMTEtMTItMDEgYXQgMDk6MTIgKzAxMDAsIFNlYmFzdGlhbiBBbmRyemVq IFNpZXdpb3Igd3JvdGU6DQo+ID4+IE9uIDExLzMwLzIwMTEgMTE6MDMgUE0sIE5pY2hvbGFzIEEu IEJlbGxpbmdlciB3cm90ZToNCj4gPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Njc2kvcWxhMnh4 eC9xbGFfZGJnLmMgYi9kcml2ZXJzL3Njc2kvcWxhMnh4eC9xbGFfZGJnLmMNCj4gPj4+IGluZGV4 IDA3MzcyZGUuLmNjMzJlYzggMTAwNjQ0DQo+ID4+PiAtLS0gYS9kcml2ZXJzL3Njc2kvcWxhMnh4 eC9xbGFfZGJnLmMNCj4gPj4+ICsrKyBiL2RyaXZlcnMvc2NzaS9xbGEyeHh4L3FsYV9kYmcuYw0K PiA+Pj4gQEAgLTE2NzYsMTEgKzE2NzYsMTEgQEAgcWxfZGJnKHVpbnQzMl90IGxldmVsLCBzY3Np X3FsYV9ob3N0X3QgKnZoYSwgaW50MzJfdCBpZCwgY2hhciAqbXNnLCAuLi4pIHsNCj4gPj4+ICAg ICB1aW50MzJfdCBsZW47DQo+ID4+PiAgICAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBOVUxMOw0K PiA+Pj4NCj4gPj4+IC0gICBtZW1zZXQocGJ1ZiwgMCwgUUxfREJHX0JVRl9MRU4pOw0KPiA+Pj4g LQ0KPiA+Pj4gICAgIHZhX3N0YXJ0KGFwLCBtc2cpOw0KPiA+Pj4NCj4gPj4+ICAgICBpZiAoKGxl dmVsJiAgcWwyeGV4dGVuZGVkX2Vycm9yX2xvZ2dpbmcpID09IGxldmVsKSB7DQo+ID4+PiArICAg ICAgICAgICBtZW1zZXQocGJ1ZiwgMCwgUUxfREJHX0JVRl9MRU4pOw0KPiA+Pj4gKw0KPiA+Pg0K PiA+PiA1MTJieXRlcyBvbiB0aGUgc3RhY2sgaXMgYnJhdmUuDQo+ID4NCj4gPiAuLi4NCj4gPg0K PiA+PiAgQW55d2F5LCB3aHkgZG8geW91IG1lbXNldCB0aGUgd2hvbGUNCj4gPj4gYnVmZmVyPyBB cyBmYXIgdGhlIHN0cmluZyBwcm9jZXNzaW5nIGlzIGNvbmNlcm5lZCwgc2V0dGluZyB0aGUgZmly c3QNCj4gPj4gYnl0ZSB0byB6ZXJvIGlzIGVub3VnaC4NCj4gPj4NCj4gPg0KPiA+IEFmdGVyIGNv bnZlcnRpbmcgcWxhX3RhcmdldC5jIGluIGEgZmV3IGh1bmRyZWQgbG9jYXRpb25zIHRvIHVzZQ0K PiA+IHFsYV9kYmcoKSBteSB3cmlzdHMgYXJlIHN0aWxsIGh1cnRpbmcsIHNvIHlvdSBjYW4gaW1h Z2luZSBJJ20gbm90IHJlYWwNCj4gPiBlYWdlciB0byBsb29rIGludG8gdGhpcyBjb2RlLiAgOykN Cj4gPg0KPiA+IEFueXdheXMsIG1lbXNldCBvZiB0aGUgd2hvbGUgYnVmZmVyIGlzIG92ZXJraWxs LiAgU2luY2Ugc3ByaW50ZigpIGlzDQo+ID4gYmVpbmcgdXNlZCBmb3IgcWxhX2RiZy5jIGNhc2Vz LCBldmVuIHRoZSAxIGJ5dGUgbWVtc2V0IGlzIHVubmVjZXNzYXJ5Lg0KPiANCj4gSSBkbyB3YW50 IHRvIG5vdGUgdGhhdCB0aGVyZSBpcyBhIHBhdGNoIHBvc3RlZCBhbHJlYWR5IHRoYXQgcmVtb3Zl cyB0aGUNCj4gbWVtc2V0IGFzIHdlbGw6DQo+IGh0dHA6Ly9tYXJjLmluZm8vP2w9bGludXgtc2Nz aSZtPTEzMjE2MzY2NDgwOTg1NiZ3PTIuDQoNClNvIHNpbmNlIHRoYXQgb25lIGNhbWUgZnJvbSB5 b3UgYXMgcGFydCBvZiBhIHNlcmllcywgSSB3YXMgb3JpZ2luYWxseQ0KcGxhbm5pbmcgdG8gbWVy Z2UgaXQgYmVmb3JlIHlvdSBhY2tlZCB0aGlzIG9uZSwgd2hpY2ggYmFzaWNhbGx5IG1ha2VzDQp0 aGlzIG9uZSByZWR1bmRhbnQgKGFuZCBjb25mbGljdGluZyksIGRvZXNuJ3QgaXQ/ICBXaGljaCBw YXRjaCBkaWQgeW91DQp3YW50IG1lIHRvIHRha2UsIHNpbmNlIEkgY2FuJ3QgdGFrZSBib3RoPw0K DQpKYW1lcw0KDQo=