From: Sasha Levin <levinsasha928@gmail.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 2/2] KVM: Correct documentation of KVM_GET_SUPPORTED_CPUID
Date: Sun, 04 Dec 2011 19:37:50 +0200 [thread overview]
Message-ID: <1323020270.3256.4.camel@lappy> (raw)
In-Reply-To: <1321525125-28966-2-git-send-email-levinsasha928@gmail.com>
Avi,
This is the other part of the get_supported_cpuid change. We discussed
it over IRC and you said it looks right.
On Thu, 2011-11-17 at 12:18 +0200, Sasha Levin wrote:
> If the amount of entries available passed to KVM_GET_SUPPORTED_CPUID is
> too big we don't fail, we just adjust it to the amount actually needed
> and fill the entries.
>
> Cc: Avi Kivity <avi@redhat.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> Documentation/virtual/kvm/api.txt | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 7945b0b..273be09 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1074,10 +1074,9 @@ or for feature consistency across a cluster).
> Userspace invokes KVM_GET_SUPPORTED_CPUID by passing a kvm_cpuid2 structure
> with the 'nent' field indicating the number of entries in the variable-size
> array 'entries'. If the number of entries is too low to describe the cpu
> -capabilities, an error (E2BIG) is returned. If the number is too high,
> -the 'nent' field is adjusted and an error (ENOMEM) is returned. If the
> -number is just right, the 'nent' field is adjusted to the number of valid
> -entries in the 'entries' array, which is then filled.
> +capabilities, an error (E2BIG) is returned. If the number is above or just,
> +right, the 'nent' field is adjusted to the number of valid entries in the
> +'entries' array, which is then filled.
>
> The entries returned are the host cpuid as returned by the cpuid instruction,
> with unknown or unsupported features masked out. Some features (for example,
--
Sasha.
next prev parent reply other threads:[~2011-12-04 17:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 10:18 [PATCH 1/2] KVM: Don't fail KVM_GET_SUPPORTED_CPUID if nent is just right Sasha Levin
2011-11-17 10:18 ` [PATCH 2/2] KVM: Correct documentation of KVM_GET_SUPPORTED_CPUID Sasha Levin
2011-12-04 17:37 ` Sasha Levin [this message]
2011-11-24 10:09 ` [PATCH 1/2] KVM: Don't fail KVM_GET_SUPPORTED_CPUID if nent is just right Marcelo Tosatti
2011-11-24 10:31 ` Sasha Levin
2011-11-24 10:33 ` Avi Kivity
2011-11-24 10:37 ` Sasha Levin
2011-11-24 10:45 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323020270.3256.4.camel@lappy \
--to=levinsasha928@gmail.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.