From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH 01/16 v3] pmac_zilog: fix unexpected irq Date: Thu, 08 Dec 2011 15:30:38 +1100 Message-ID: <1323318638.12793.23.camel@pasglop> References: <20111023141108.856998818@telegraphics.com.au> <20111023141115.208699274@telegraphics.com.au> <1323318004.12793.21.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from gate.crashing.org ([63.228.1.57]:41625 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761Ab1LHEau (ORCPT ); Wed, 7 Dec 2011 23:30:50 -0500 In-Reply-To: <1323318004.12793.21.camel@pasglop> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Finn Thain Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org On Thu, 2011-12-08 at 15:20 +1100, Benjamin Herrenschmidt wrote: > So basic operations seem to work, I've applied the patch to > powerpc-next. > > However, the internal modem on my Pismo powerbook doesn't appear to > survive suspend/resume. I'll dig into that and merge a fixup patch asap. BTW. I applied anyway because suspend/resume was already broken (you spotted that we don't clear the suspended flag for example). Fixing the flag alone helps a bit. We can't use the modem if we suspend/resume with the open port, but closing and re-opening works. Lockdep also picked-up a A->B B->A between the port mutex and the pmz irq mutex on suspend. I'll try to fix all these, and will let you know (I may not have time today). Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 869211007D8 for ; Thu, 8 Dec 2011 15:30:48 +1100 (EST) Message-ID: <1323318638.12793.23.camel@pasglop> Subject: Re: [PATCH 01/16 v3] pmac_zilog: fix unexpected irq From: Benjamin Herrenschmidt To: Finn Thain Date: Thu, 08 Dec 2011 15:30:38 +1100 In-Reply-To: <1323318004.12793.21.camel@pasglop> References: <20111023141108.856998818@telegraphics.com.au> <20111023141115.208699274@telegraphics.com.au> <1323318004.12793.21.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, linux-m68k@vger.kernel.org, Geert Uytterhoeven , linux-serial@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2011-12-08 at 15:20 +1100, Benjamin Herrenschmidt wrote: > So basic operations seem to work, I've applied the patch to > powerpc-next. > > However, the internal modem on my Pismo powerbook doesn't appear to > survive suspend/resume. I'll dig into that and merge a fixup patch asap. BTW. I applied anyway because suspend/resume was already broken (you spotted that we don't clear the suspended flag for example). Fixing the flag alone helps a bit. We can't use the modem if we suspend/resume with the open port, but closing and re-opening works. Lockdep also picked-up a A->B B->A between the port mutex and the pmz irq mutex on suspend. I'll try to fix all these, and will let you know (I may not have time today). Cheers, Ben.